Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Issue 1864263002: Revert conversion of SkColorFilterImageFilter to new API (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -37 lines) Patch
M include/effects/SkColorFilterImageFilter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkColorFilterImageFilter.cpp View 2 chunks +27 lines, -35 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
robertphillips
A simple revert isn't possible due to intervening CLs.
4 years, 8 months ago (2016-04-06 19:25:35 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864263002/1
4 years, 8 months ago (2016-04-06 19:52:43 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-06 20:05:38 UTC) #8
robertphillips
ping
4 years, 8 months ago (2016-04-07 14:42:48 UTC) #9
Stephen White
On 2016/04/07 14:42:48, robertphillips wrote: > ping Sorry; I had assumed you were landing TBR, ...
4 years, 8 months ago (2016-04-07 14:44:26 UTC) #10
robertphillips
On 2016/04/07 14:44:26, Stephen White wrote: > On 2016/04/07 14:42:48, robertphillips wrote: > > ping ...
4 years, 8 months ago (2016-04-07 14:47:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864263002/1
4 years, 8 months ago (2016-04-07 15:09:49 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 15:10:48 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6f01104b1d86b861b366b3511c8f2567eca4a9f3

Powered by Google App Engine
This is Rietveld 408576698