| Index: src/effects/SkColorFilterImageFilter.cpp
|
| diff --git a/src/effects/SkColorFilterImageFilter.cpp b/src/effects/SkColorFilterImageFilter.cpp
|
| index 8d412cc2f5579967e9d304c443183f5b5855ae7b..63dded6a184f0bad3114b674415ebd319f889618 100644
|
| --- a/src/effects/SkColorFilterImageFilter.cpp
|
| +++ b/src/effects/SkColorFilterImageFilter.cpp
|
| @@ -9,9 +9,8 @@
|
|
|
| #include "SkCanvas.h"
|
| #include "SkColorFilter.h"
|
| +#include "SkDevice.h"
|
| #include "SkReadBuffer.h"
|
| -#include "SkSpecialImage.h"
|
| -#include "SkSpecialSurface.h"
|
| #include "SkWriteBuffer.h"
|
|
|
| sk_sp<SkImageFilter> SkColorFilterImageFilter::Make(sk_sp<SkColorFilter> cf,
|
| @@ -57,62 +56,55 @@ void SkColorFilterImageFilter::flatten(SkWriteBuffer& buffer) const {
|
| buffer.writeFlattenable(fColorFilter.get());
|
| }
|
|
|
| -sk_sp<SkSpecialImage> SkColorFilterImageFilter::onFilterImage(SkSpecialImage* source,
|
| - const Context& ctx,
|
| - SkIPoint* offset) const {
|
| - SkIPoint inputOffset = SkIPoint::Make(0, 0);
|
| - sk_sp<SkSpecialImage> input(this->filterInput(0, source, ctx, &inputOffset));
|
| +bool SkColorFilterImageFilter::onFilterImageDeprecated(Proxy* proxy, const SkBitmap& source,
|
| + const Context& ctx,
|
| + SkBitmap* result,
|
| + SkIPoint* offset) const {
|
| + SkBitmap src = source;
|
| + SkIPoint srcOffset = SkIPoint::Make(0, 0);
|
| + bool inputResult = this->filterInputDeprecated(0, proxy, source, ctx, &src, &srcOffset);
|
| +
|
| + SkIRect srcBounds;
|
|
|
| - SkIRect inputBounds;
|
| if (fColorFilter->affectsTransparentBlack()) {
|
| // If the color filter affects transparent black, the bounds are the entire clip.
|
| - inputBounds = ctx.clipBounds();
|
| - } else if (!input) {
|
| - return nullptr;
|
| + srcBounds = ctx.clipBounds();
|
| + } else if (!inputResult) {
|
| + return false;
|
| } else {
|
| - inputBounds = SkIRect::MakeXYWH(inputOffset.x(), inputOffset.y(),
|
| - input->width(), input->height());
|
| + srcBounds = src.bounds();
|
| + srcBounds.offset(srcOffset);
|
| }
|
|
|
| SkIRect bounds;
|
| - if (!this->applyCropRect(ctx, inputBounds, &bounds)) {
|
| - return nullptr;
|
| + if (!this->applyCropRect(ctx, srcBounds, &bounds)) {
|
| + return false;
|
| }
|
|
|
| - SkImageInfo info = SkImageInfo::MakeN32(bounds.width(), bounds.height(), kPremul_SkAlphaType);
|
| - sk_sp<SkSpecialSurface> surf(source->makeSurface(info));
|
| - if (!surf) {
|
| - return nullptr;
|
| + SkAutoTUnref<SkBaseDevice> device(proxy->createDevice(bounds.width(), bounds.height()));
|
| + if (nullptr == device.get()) {
|
| + return false;
|
| }
|
| -
|
| - SkCanvas* canvas = surf->getCanvas();
|
| - SkASSERT(canvas);
|
| + SkCanvas canvas(device.get());
|
|
|
| SkPaint paint;
|
| -
|
| paint.setXfermodeMode(SkXfermode::kSrc_Mode);
|
| paint.setColorFilter(fColorFilter);
|
|
|
| // TODO: it may not be necessary to clear or drawPaint inside the input bounds
|
| // (see skbug.com/5075)
|
| if (fColorFilter->affectsTransparentBlack()) {
|
| - // The subsequent input->draw() call may not fill the entire canvas. For filters which
|
| + // The subsequent drawBitmap call may not fill the entire canvas. For filters which
|
| // affect transparent black, ensure that the filter is applied everywhere.
|
| - canvas->drawPaint(paint);
|
| - } else {
|
| - canvas->clear(0x0);
|
| - }
|
| -
|
| - if (input) {
|
| - input->draw(canvas,
|
| - SkIntToScalar(inputOffset.fX - bounds.fLeft),
|
| - SkIntToScalar(inputOffset.fY - bounds.fTop),
|
| - &paint);
|
| + canvas.drawPaint(paint);
|
| }
|
|
|
| + canvas.drawBitmap(src, SkIntToScalar(srcOffset.fX - bounds.fLeft),
|
| + SkIntToScalar(srcOffset.fY - bounds.fTop), &paint);
|
| + *result = device.get()->accessBitmap(false);
|
| offset->fX = bounds.fLeft;
|
| offset->fY = bounds.fTop;
|
| - return surf->makeImageSnapshot();
|
| + return true;
|
| }
|
|
|
| bool SkColorFilterImageFilter::onIsColorFilterNode(SkColorFilter** filter) const {
|
|
|