Issue 1864143002: Add instruction tags to saved ICData (debug mode only).

Issue 1864143002: Add instruction tags to saved ICData (debug mode only). (Closed)

Created:
4 years, 8 months ago by srdjan

Modified:
4 years, 8 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org, siva

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Add instruction tags to saved ICData (debug mode only). When restoring ICData in optimizing compiler, we can verify that the ICData/deopt-id matches an instruction. This should help catch non-deterministic graph generation. BUG= R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/cef337f8c7082fa977984f0bb11a8b28e9a9d2eb

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -1 line)			Patch
M	runtime/platform/globals.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 chunk	+9 lines, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	3 chunks	+12 lines, -0 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

srdjan

4 years, 8 months ago (2016-04-06 18:01:52 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cef337f8c7082fa977984f0bb11a8b28e9a9d2eb (presubmit successful).