Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: runtime/vm/intermediate_language.cc

Issue 1864143002: Add instruction tags to saved ICData (debug mode only). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.cc
diff --git a/runtime/vm/intermediate_language.cc b/runtime/vm/intermediate_language.cc
index 5b5ac04d502a2b9096de257f0f69903968046088..231e9eff503f63daa550b4697714bcdce4304410 100644
--- a/runtime/vm/intermediate_language.cc
+++ b/runtime/vm/intermediate_language.cc
@@ -89,7 +89,15 @@ const ICData* Instruction::GetICData(
// computations added in the optimizing compiler.
ASSERT(deopt_id_ != Thread::kNoDeoptId);
if (deopt_id_ < ic_data_array.length()) {
- return ic_data_array[deopt_id_];
+ const ICData* result = ic_data_array[deopt_id_];
+#if defined(TAG_IC_DATA)
+ if (result->tag() == -1) {
+ result->set_tag(tag());
+ } else if (result->tag() != tag()) {
+ FATAL("ICData tag mismatch");
+ }
+#endif
+ return result;
}
return NULL;
}
« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698