Fixes problems with drawn state

Fixes problems with drawn state

There were two problems with how the drawn state was previously
communicated:
. the drawn state included the visibility of the window. This meant
  that if a window was hidden it's drawn state was also false, so that
  when the visibility was made true the client didn't know that it
  should make the drawn state true as well.
. the drawn state was communicated for all windows, when really all that
  matters is the drawn state of the root windows.

To fix this I changed the following:
. the drawn state is communicated via OnEmbed or OnTopLevelCreated().
. the drawn state is the drawn state of the windows parent, not the
  window. This way it doesn't included the visibility of the
  window. This fixes the problem I mentioned above so that when a
  client changes the visibility it doesn't impact the drawn state.
. NewTopLevelWindow() sets drawn to true (which is generally what the
  wm will do). This way focus requests won't silently fail in the client.

BUG=600868
TEST=covered by tests
R=ben@chromium.org

Committed: https://crrev.com/e61c75b5abf6e7234b26f10bb0d493bb32fea073
Cr-Commit-Position: refs/heads/master@{#385641}

[Ben Goodger (Google), 2016-04-06 15:57:05]

lgtm with nit:

https://codereview.chromium.org/1864113002/diff/40001/components/mus/public/i...
File components/mus/public/interfaces/window_tree.mojom (right):

https://codereview.chromium.org/1864113002/diff/40001/components/mus/public/i...
components/mus/public/interfaces/window_tree.mojom:271: // OnDrawnStateChanged()
for details.
OnWindowParentDrawnStateChanged()

[sky, 2016-04-07 02:33:54]

The CQ bit was checked by sky@chromium.org

[sky, 2016-04-07 02:33:54]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/1864113002/#ps60001
(title: "parentdrawn and merge")

[sky, 2016-04-07 02:33:58]

https://codereview.chromium.org/1864113002/diff/40001/components/mus/public/i...
File components/mus/public/interfaces/window_tree.mojom (right):

https://codereview.chromium.org/1864113002/diff/40001/components/mus/public/i...
components/mus/public/interfaces/window_tree.mojom:271: // OnDrawnStateChanged()
for details.
On 2016/04/06 15:57:04, Ben Goodger (Google) wrote:
> OnWindowParentDrawnStateChanged()

Done.

[commit-bot: I haz the power, 2016-04-07 02:34:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1864113002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1864113002/60001

[commit-bot: I haz the power, 2016-04-07 03:14:22]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-07 03:20:03]

Description was changed from

==========
Fixes problems with drawn state

There were two problems with how the drawn state was previously
communicated:
. the drawn state included the visibility of the window. This meant
  that if a window was hidden it's drawn state was also false, so that
  when the visibility was made true the client didn't know that it
  should make the drawn state true as well.
. the drawn state was communicated for all windows, when really all that
  matters is the drawn state of the root windows.

To fix this I changed the following:
. the drawn state is communicated via OnEmbed or OnTopLevelCreated().
. the drawn state is the drawn state of the windows parent, not the
  window. This way it doesn't included the visibility of the
  window. This fixes the problem I mentioned above so that when a
  client changes the visibility it doesn't impact the drawn state.
. NewTopLevelWindow() sets drawn to true (which is generally what the
  wm will do). This way focus requests won't silently fail in the client.

BUG=600868
TEST=covered by tests
R=ben@chromium.org
==========

to

==========
Fixes problems with drawn state

There were two problems with how the drawn state was previously
communicated:
. the drawn state included the visibility of the window. This meant
  that if a window was hidden it's drawn state was also false, so that
  when the visibility was made true the client didn't know that it
  should make the drawn state true as well.
. the drawn state was communicated for all windows, when really all that
  matters is the drawn state of the root windows.

To fix this I changed the following:
. the drawn state is communicated via OnEmbed or OnTopLevelCreated().
. the drawn state is the drawn state of the windows parent, not the
  window. This way it doesn't included the visibility of the
  window. This fixes the problem I mentioned above so that when a
  client changes the visibility it doesn't impact the drawn state.
. NewTopLevelWindow() sets drawn to true (which is generally what the
  wm will do). This way focus requests won't silently fail in the client.

BUG=600868
TEST=covered by tests
R=ben@chromium.org

Committed: https://crrev.com/e61c75b5abf6e7234b26f10bb0d493bb32fea073
Cr-Commit-Position: refs/heads/master@{#385641}
==========

[commit-bot: I haz the power, 2016-04-07 03:20:04]

Patchset 4 (id:??) landed as
https://crrev.com/e61c75b5abf6e7234b26f10bb0d493bb32fea073
Cr-Commit-Position: refs/heads/master@{#385641}