Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: components/mus/public/cpp/window.h

Issue 1864113002: Fixes problems with drawn state (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: parentdrawn and merge Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/mus/public/cpp/window.h
diff --git a/components/mus/public/cpp/window.h b/components/mus/public/cpp/window.h
index 3737d40aef9ca1827841ca0158155a055428fbcf..73a0048fd1e8093b0449b99f6ea1165b6db18126 100644
--- a/components/mus/public/cpp/window.h
+++ b/components/mus/public/cpp/window.h
@@ -253,7 +253,7 @@ class Window {
const std::vector<gfx::Rect>& additional_client_areas);
void LocalSetViewportMetrics(const mojom::ViewportMetrics& old_metrics,
const mojom::ViewportMetrics& new_metrics);
- void LocalSetDrawn(bool drawn);
+ void LocalSetParentDrawn(bool drawn);
void LocalSetVisible(bool visible);
void LocalSetPredefinedCursor(mojom::Cursor cursor_id);
void LocalSetSharedProperty(const std::string& name,
@@ -316,10 +316,9 @@ class Window {
SharedProperties properties_;
- // Drawn state is derived from the visible state and the parent's visible
- // state. This field is only used if the window has no parent (eg it's a
- // root).
- bool drawn_;
+ // Drawn state of our parent. This is only meaningful for root Windows, in
+ // which the parent Window isn't exposed to the client.
+ bool parent_drawn_;
// Value struct to keep the name and deallocator for this property.
// Key cannot be used for this purpose because it can be char* or
« no previous file with comments | « components/mus/public/cpp/tests/window_unittest.cc ('k') | components/mus/public/interfaces/window_tree.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698