Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1864063002:
Add features for V8 serialization experiments. (Closed)
DescriptionAdd features (feature flags) for V8 serialization experiments.
The intent is to evaluate these w/ Finch, starting with M51.
Context on those two features: crbug.com/594551, crrev.com/1804433004
BUG=chromium:594551
Committed: https://crrev.com/d2a197f04ebac1ec78ecd1598c0a94c2d49bf64c
Cr-Commit-Position: refs/heads/master@{#385746}
Patch Set 1 #Patch Set 2 : cl format #
Total comments: 3
Messages
Total messages: 16 (7 generated)
Description was changed from ========== Add features for V8 serialization experiments. The intent is to evaluate these features w/ Finch, starting with M51. Context on those two features: crbug.com/594551, crrev.com/1804433004 BUG=chromium:594551 ========== to ========== Add features (feature flags) for V8 serialization experiments. The intent is to evaluate these w/ Finch, starting with M51. Context on those two features: crbug.com/594551, crrev.com/1804433004 BUG=chromium:594551 ==========
vogelheim@chromium.org changed reviewers: + jochen@chromium.org, yangguo@chromium.org
https://codereview.chromium.org/1864063002/diff/20001/chrome/renderer/chrome_... File chrome/renderer/chrome_render_process_observer.cc (right): https://codereview.chromium.org/1864063002/diff/20001/chrome/renderer/chrome_... chrome/renderer/chrome_render_process_observer.cc:242: const base::Feature kV8SerializeEagerFeature{"V8_Serialize_Eager", This doesn't look right, but this is what "git cl format" produces. I guess I should drop this change set?
lgtm https://codereview.chromium.org/1864063002/diff/20001/chrome/renderer/chrome_... File chrome/renderer/chrome_render_process_observer.cc (right): https://codereview.chromium.org/1864063002/diff/20001/chrome/renderer/chrome_... chrome/renderer/chrome_render_process_observer.cc:242: const base::Feature kV8SerializeEagerFeature{"V8_Serialize_Eager", On 2016/04/06 at 12:57:43, vogelheim wrote: > This doesn't look right, but this is what "git cl format" produces. I guess I should drop this change set? can you file a bug (go/clang-format-bug)
https://codereview.chromium.org/1864063002/diff/20001/chrome/renderer/chrome_... File chrome/renderer/chrome_render_process_observer.cc (right): https://codereview.chromium.org/1864063002/diff/20001/chrome/renderer/chrome_... chrome/renderer/chrome_render_process_observer.cc:242: const base::Feature kV8SerializeEagerFeature{"V8_Serialize_Eager", - This is intentional on clang-format's part. (b/28035242) - Google style guide - which is referenced by Chromium style guide - wants curly braces to be used like a function call. - Chromium isn't yet sure what to do with this: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/GF96FshwHLw - Usage in Chromium is inconsistent: https://code.google.com/p/chromium/codesearch#search/&q=base::Feature%5C%20%5...
lgtm as clang-format formats it
The CQ bit was checked by vogelheim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864063002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by vogelheim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864063002/20001
Message was sent while issue was closed.
Description was changed from ========== Add features (feature flags) for V8 serialization experiments. The intent is to evaluate these w/ Finch, starting with M51. Context on those two features: crbug.com/594551, crrev.com/1804433004 BUG=chromium:594551 ========== to ========== Add features (feature flags) for V8 serialization experiments. The intent is to evaluate these w/ Finch, starting with M51. Context on those two features: crbug.com/594551, crrev.com/1804433004 BUG=chromium:594551 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add features (feature flags) for V8 serialization experiments. The intent is to evaluate these w/ Finch, starting with M51. Context on those two features: crbug.com/594551, crrev.com/1804433004 BUG=chromium:594551 ========== to ========== Add features (feature flags) for V8 serialization experiments. The intent is to evaluate these w/ Finch, starting with M51. Context on those two features: crbug.com/594551, crrev.com/1804433004 BUG=chromium:594551 Committed: https://crrev.com/d2a197f04ebac1ec78ecd1598c0a94c2d49bf64c Cr-Commit-Position: refs/heads/master@{#385746} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/d2a197f04ebac1ec78ecd1598c0a94c2d49bf64c Cr-Commit-Position: refs/heads/master@{#385746} |
