Add features for V8 serialization experiments.

chrome/renderer/chrome_render_process_observer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_render_process_observer.h"
 
 #include <stddef.h>
 #include <limits>
 #include <set>
 #include <utility>
@@ skipping 221 matching lines @@
 void CreateResourceUsageReporter(
     base::WeakPtr<ChromeRenderProcessObserver> observer,
     mojo::InterfaceRequest<mojom::ResourceUsageReporter> request) {
   new ResourceUsageReporterImpl(observer, std::move(request));
 }
 
 const base::Feature kV8_ES2015_TailCalls_Feature {
   "V8_ES2015_TailCalls", base::FEATURE_DISABLED_BY_DEFAULT
 };
 
+const base::Feature kV8SerializeEagerFeature{"V8_Serialize_Eager",

[vogelheim, 2016/04/06 12:57:43]

This doesn't look right, but this is what "git cl format" produces. I guess I
should drop this change set?

[jochen (gone - plz use gerrit), 2016/04/06 13:00:56]

can you file a bug (go/clang-format-bug)

[vogelheim, 2016/04/06 13:44:00]

- This is intentional on clang-format's part. (b/28035242)
- Google style guide - which is referenced by Chromium style guide - wants curly
braces to be used like a function call.
- Chromium isn't yet sure what to do with this:
 
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/GF96FshwHLw
- Usage in Chromium is inconsistent:
 
https://code.google.com/p/chromium/codesearch#search/&q=base::Feature%5C%20%5...

+                                             base::FEATURE_DISABLED_BY_DEFAULT};
+
+const base::Feature kV8SerializeAgeCodeFeature{
+    "V8_Serialize_Age_Code", base::FEATURE_DISABLED_BY_DEFAULT};
+
+void SetV8FlagIfFeature(const base::Feature& feature, const char* v8_flag) {
+  if (base::FeatureList::IsEnabled(feature)) {
+    v8::V8::SetFlagsFromString(v8_flag, strlen(v8_flag));
+  }
+}
+
+void SetV8FlagIfHasSwitch(const char* switch_name, const char* v8_flag) {
+  if (base::CommandLine::ForCurrentProcess()->HasSwitch(switch_name)) {
+    v8::V8::SetFlagsFromString(v8_flag, strlen(v8_flag));
+  }
+}
+
 }  // namespace
 
 bool ChromeRenderProcessObserver::is_incognito_process_ = false;
 
 ChromeRenderProcessObserver::ChromeRenderProcessObserver()
     : weak_factory_(this) {
   const base::CommandLine& command_line =
       *base::CommandLine::ForCurrentProcess();
 
 #if defined(ENABLE_AUTOFILL_DIALOG)
   WebRuntimeFeatures::enableRequestAutocomplete(true);
 #endif
 
-  if (base::FeatureList::IsEnabled(kV8_ES2015_TailCalls_Feature)) {
-    std::string flag("--harmony-tailcalls");
-    v8::V8::SetFlagsFromString(flag.c_str(), static_cast<int>(flag.size()));
-  }
-
-  if (command_line.HasSwitch(switches::kDisableJavaScriptHarmonyShipping)) {
-    std::string flag("--noharmony-shipping");
-    v8::V8::SetFlagsFromString(flag.c_str(), static_cast<int>(flag.size()));
-  }
-
-  if (command_line.HasSwitch(switches::kJavaScriptHarmony)) {
-    std::string flag("--harmony");
-    v8::V8::SetFlagsFromString(flag.c_str(), static_cast<int>(flag.size()));
-  }
-
-  if (command_line.HasSwitch(switches::kEnableWasm)) {
-    std::string flag("--expose-wasm");
-    v8::V8::SetFlagsFromString(flag.c_str(), static_cast<int>(flag.size()));
-  }
+  SetV8FlagIfFeature(kV8_ES2015_TailCalls_Feature, "--harmony-tailcalls");
+  SetV8FlagIfFeature(kV8SerializeEagerFeature, "--serialize_eager");
+  SetV8FlagIfFeature(kV8SerializeAgeCodeFeature, "--serialize_age_code");
+  SetV8FlagIfHasSwitch(switches::kDisableJavaScriptHarmonyShipping,
+                       "--noharmony-shipping");
+  SetV8FlagIfHasSwitch(switches::kJavaScriptHarmony, "--harmony");
+  SetV8FlagIfHasSwitch(switches::kEnableWasm, "--expose-wasm");
 
   RenderThread* thread = RenderThread::Get();
   resource_delegate_.reset(new RendererResourceDelegate());
   thread->SetResourceDispatcherDelegate(resource_delegate_.get());
 
   thread->GetServiceRegistry()->AddService(
       base::Bind(CreateResourceUsageReporter, weak_factory_.GetWeakPtr()));
 
   // Configure modules that need access to resources.
   net::NetModule::SetResourceProvider(chrome_common_net::NetResourceProvider);
@@ skipping 110 matching lines @@
 ChromeRenderProcessObserver::content_setting_rules() const {
   return &content_setting_rules_;
 }
 
 void ChromeRenderProcessObserver::OnFieldTrialGroupFinalized(
     const std::string& trial_name,
     const std::string& group_name) {
   content::RenderThread::Get()->Send(
       new ChromeViewHostMsg_FieldTrialActivated(trial_name));
 }