Issue 18640005: Rename PNaClTranslationCache->PnaclTranslationCache to match convention elsewhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18640005: Rename PNaClTranslationCache->PnaclTranslationCache to match convention elsewhere (Closed)

Created:
7 years, 5 months ago by Derek Schuff

Modified:
7 years, 5 months ago

Reviewers:
jvoung (off chromium)

CC:
chromium-reviews, native-client-reviews_googlegroups.com, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Rename PNaClTranslationCache->PnaclTranslationCache to match convention elsewhere PNaClFoo is spelled "PnaclFoo" everywhere else in Chromium, so be consistent. R=jvoung@chromium.org BUG= https://code.google.com/p/nativeclient/issues/detail?id=3372 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211403

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -70 lines)			Patch
M	chrome/browser/nacl_host/pnacl_translation_cache.h	View	3 chunks	+11 lines, -11 lines	0 comments	Download
M	chrome/browser/nacl_host/pnacl_translation_cache.cc	View	16 chunks	+40 lines, -40 lines	0 comments	Download
M	chrome/browser/nacl_host/pnacl_translation_cache_unittest.cc	View	10 chunks	+18 lines, -18 lines	0 comments	Download
M	tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dschuff@chromium.org/18640005/1

7 years, 5 months ago (2013-07-11 23:43:01 UTC) #3

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=148325

7 years, 5 months ago (2013-07-12 01:57:56 UTC) #4

Derek Schuff

7 years, 5 months ago (2013-07-12 15:50:16 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r211403 (presubmit successful).

Expand Messages | Collapse Messages