Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 1863983006: TaskScheduler: Small improvements in SchedulerWorkerThreadTest. (Closed)

Created:
4 years, 8 months ago by fdoray
Modified:
4 years, 8 months ago
Reviewers:
gab
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@delegate
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

TaskScheduler: Small improvements in SchedulerWorkerThreadTest. - Verify that SchedulerWorkerThread doesn't do more work than expected. - Fix typo. - Clarify comments. BUG=553459 Committed: https://crrev.com/4701f435ba875309bdfa2ebd1c589f2717f725cb Cr-Commit-Position: refs/heads/master@{#385911}

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR gab #5 (1 -> one) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -17 lines) Patch
M base/task_scheduler/scheduler_worker_thread_unittest.cc View 1 5 chunks +25 lines, -17 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (7 generated)
fdoray
gab@: Can you review this CL?
4 years, 8 months ago (2016-04-07 13:56:12 UTC) #2
gab
owner lgtm (no need to ping Dana for this), thanks! https://codereview.chromium.org/1863983006/diff/1/base/task_scheduler/scheduler_worker_thread_unittest.cc File base/task_scheduler/scheduler_worker_thread_unittest.cc (right): https://codereview.chromium.org/1863983006/diff/1/base/task_scheduler/scheduler_worker_thread_unittest.cc#newcode217 ...
4 years, 8 months ago (2016-04-07 15:47:36 UTC) #5
fdoray
https://codereview.chromium.org/1863983006/diff/1/base/task_scheduler/scheduler_worker_thread_unittest.cc File base/task_scheduler/scheduler_worker_thread_unittest.cc (right): https://codereview.chromium.org/1863983006/diff/1/base/task_scheduler/scheduler_worker_thread_unittest.cc#newcode217 base/task_scheduler/scheduler_worker_thread_unittest.cc:217: // Sequence and 1 call in which its returns ...
4 years, 8 months ago (2016-04-07 22:17:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863983006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863983006/20001
4 years, 8 months ago (2016-04-07 22:17:49 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-07 22:58:25 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 22:59:48 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4701f435ba875309bdfa2ebd1c589f2717f725cb
Cr-Commit-Position: refs/heads/master@{#385911}

Powered by Google App Engine
This is Rietveld 408576698