Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: common/api/logdog_coordinator/services/v1/tasks.proto

Issue 1863973002: LogDog: Update to archival V2. (Closed) Base URL: https://github.com/luci/luci-go@grpcutil-errors
Patch Set: Fix proto comment. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: common/api/logdog_coordinator/services/v1/tasks.proto
diff --git a/common/api/logdog_coordinator/services/v1/tasks.proto b/common/api/logdog_coordinator/services/v1/tasks.proto
index d208f61c5ae35038c641011b42e00361d355dc36..60e07f425a64845e76c6b183ef1a395be1812d8e 100644
--- a/common/api/logdog_coordinator/services/v1/tasks.proto
+++ b/common/api/logdog_coordinator/services/v1/tasks.proto
@@ -6,12 +6,30 @@ syntax = "proto3";
package logdog;
+import "google/protobuf/duration.proto";
+
// ArchiveTask is a task queue task description for the archival of a single
// log stream.
message ArchiveTask {
// The path of the log stream to archive.
string path = 1;
- // If true, require that the log stream be complete.
- bool complete = 2;
+ // The archival key of the log stream. If this key doesn't match the key in
+ // the log stream state, the request is superfluous and should be deleted.
+ bytes key = 2;
+
+ // Don't waste time archiving the log stream until it is at least this old.
+ //
+ // This is in place to prevent overly-aggressive archivals from wasting time
+ // trying, then failing, becuase the log stream data is still being collected
+ // into intermediate storage.
+ google.protobuf.Duration settle_delay = 3;
+
+ // The amount of time after the task was created that log stream completeness
+ // will be used as a success criteria. If the task's age is older than this
+ // value, completeness will not be enforced.
+ //
+ // The task's age can be calculated by subtracting its lease expiration time
+ // (leaseTimestamp) from its enqueued timestamp (enqueueTimestamp).
+ google.protobuf.Duration complete_period = 4;
}
« no previous file with comments | « common/api/logdog_coordinator/services/v1/state.pb.go ('k') | common/api/logdog_coordinator/services/v1/tasks.pb.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698