Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: common/api/logdog_coordinator/services/v1/tasks.pb.go

Issue 1863973002: LogDog: Update to archival V2. (Closed) Base URL: https://github.com/luci/luci-go@grpcutil-errors
Patch Set: Fix proto comment. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: common/api/logdog_coordinator/services/v1/tasks.pb.go
diff --git a/common/api/logdog_coordinator/services/v1/tasks.pb.go b/common/api/logdog_coordinator/services/v1/tasks.pb.go
index e5abacdbb68ad19c5b8d79c721911d98d91bde6a..04aab2b7a96fbf60fd6be57b3f9c1701d170ed07 100644
--- a/common/api/logdog_coordinator/services/v1/tasks.pb.go
+++ b/common/api/logdog_coordinator/services/v1/tasks.pb.go
@@ -7,6 +7,7 @@ package logdog
import proto "github.com/golang/protobuf/proto"
import fmt "fmt"
import math "math"
+import google_protobuf1 "github.com/luci/luci-go/common/proto/google"
// Reference imports to suppress errors if they are not otherwise used.
var _ = proto.Marshal
@@ -18,8 +19,22 @@ var _ = math.Inf
type ArchiveTask struct {
// The path of the log stream to archive.
Path string `protobuf:"bytes,1,opt,name=path" json:"path,omitempty"`
- // If true, require that the log stream be complete.
- Complete bool `protobuf:"varint,2,opt,name=complete" json:"complete,omitempty"`
+ // The archival key of the log stream. If this key doesn't match the key in
+ // the log stream state, the request is superfluous and should be deleted.
+ Key []byte `protobuf:"bytes,2,opt,name=key,proto3" json:"key,omitempty"`
+ // Don't waste time archiving the log stream until it is at least this old.
+ //
+ // This is in place to prevent overly-aggressive archivals from wasting time
+ // trying, then failing, becuase the log stream data is still being collected
+ // into intermediate storage.
+ SettleDelay *google_protobuf1.Duration `protobuf:"bytes,3,opt,name=settle_delay,json=settleDelay" json:"settle_delay,omitempty"`
+ // The amount of time after the task was created that log stream completeness
+ // will be used as a success criteria. If the task's age is older than this
+ // value, completeness will not be enforced.
+ //
+ // The task's age can be calculated by subtracting its lease expiration time
+ // (leaseTimestamp) from its enqueued timestamp (enqueueTimestamp).
+ CompletePeriod *google_protobuf1.Duration `protobuf:"bytes,4,opt,name=complete_period,json=completePeriod" json:"complete_period,omitempty"`
}
func (m *ArchiveTask) Reset() { *m = ArchiveTask{} }
@@ -27,17 +42,36 @@ func (m *ArchiveTask) String() string { return proto.CompactTextStrin
func (*ArchiveTask) ProtoMessage() {}
func (*ArchiveTask) Descriptor() ([]byte, []int) { return fileDescriptor2, []int{0} }
+func (m *ArchiveTask) GetSettleDelay() *google_protobuf1.Duration {
+ if m != nil {
+ return m.SettleDelay
+ }
+ return nil
+}
+
+func (m *ArchiveTask) GetCompletePeriod() *google_protobuf1.Duration {
+ if m != nil {
+ return m.CompletePeriod
+ }
+ return nil
+}
+
func init() {
proto.RegisterType((*ArchiveTask)(nil), "logdog.ArchiveTask")
}
var fileDescriptor2 = []byte{
- // 100 bytes of a gzipped FileDescriptorProto
+ // 191 bytes of a gzipped FileDescriptorProto
0x1f, 0x8b, 0x08, 0x00, 0x00, 0x09, 0x6e, 0x88, 0x02, 0xff, 0xe2, 0xe2, 0x2e, 0x49, 0x2c, 0xce,
- 0x2e, 0xd6, 0x2b, 0x28, 0xca, 0x2f, 0xc9, 0x17, 0x62, 0xcb, 0xc9, 0x4f, 0x4f, 0xc9, 0x4f, 0x57,
- 0xb2, 0xe5, 0xe2, 0x76, 0x2c, 0x4a, 0xce, 0xc8, 0x2c, 0x4b, 0x0d, 0x01, 0xca, 0x0a, 0x09, 0x71,
- 0xb1, 0x14, 0x24, 0x96, 0x64, 0x48, 0x30, 0x2a, 0x30, 0x6a, 0x70, 0x06, 0x81, 0xd9, 0x42, 0x52,
- 0x5c, 0x1c, 0xc9, 0xf9, 0xb9, 0x05, 0x39, 0xa9, 0x25, 0xa9, 0x12, 0x4c, 0x40, 0x71, 0x8e, 0x20,
- 0x38, 0x3f, 0x89, 0x0d, 0x6c, 0x9a, 0x31, 0x20, 0x00, 0x00, 0xff, 0xff, 0x53, 0x52, 0x9b, 0x13,
- 0x5c, 0x00, 0x00, 0x00,
+ 0x2e, 0xd6, 0x2b, 0x28, 0xca, 0x2f, 0xc9, 0x17, 0x62, 0xcb, 0xc9, 0x4f, 0x4f, 0xc9, 0x4f, 0x97,
+ 0x92, 0x4b, 0xcf, 0xcf, 0x4f, 0xcf, 0x49, 0xd5, 0x07, 0x8b, 0x26, 0x95, 0xa6, 0xe9, 0xa7, 0x94,
+ 0x16, 0x25, 0x96, 0x64, 0xe6, 0xe7, 0x41, 0xd4, 0x29, 0x6d, 0x65, 0xe4, 0xe2, 0x76, 0x2c, 0x4a,
+ 0xce, 0xc8, 0x2c, 0x4b, 0x0d, 0x01, 0x6a, 0x17, 0x12, 0xe2, 0x62, 0x29, 0x48, 0x2c, 0xc9, 0x90,
+ 0x60, 0x54, 0x60, 0xd4, 0xe0, 0x0c, 0x02, 0xb3, 0x85, 0x04, 0xb8, 0x98, 0xb3, 0x53, 0x2b, 0x25,
+ 0x98, 0x80, 0x42, 0x3c, 0x41, 0x20, 0xa6, 0x90, 0x0d, 0x17, 0x4f, 0x71, 0x6a, 0x49, 0x49, 0x4e,
+ 0x6a, 0x7c, 0x4a, 0x6a, 0x4e, 0x62, 0xa5, 0x04, 0x33, 0x50, 0x8a, 0xdb, 0x48, 0x52, 0x0f, 0x62,
+ 0x99, 0x1e, 0xcc, 0x32, 0x3d, 0x17, 0xa8, 0x65, 0x41, 0xdc, 0x10, 0xe5, 0x2e, 0x20, 0xd5, 0x42,
+ 0x4e, 0x5c, 0xfc, 0xc9, 0xf9, 0xb9, 0x05, 0x39, 0xa9, 0x25, 0xa9, 0xf1, 0x05, 0xa9, 0x45, 0x99,
+ 0xf9, 0x29, 0x12, 0x2c, 0x84, 0x0c, 0xe0, 0x83, 0xe9, 0x08, 0x00, 0x6b, 0x48, 0x62, 0x03, 0x2b,
+ 0x31, 0x06, 0x04, 0x00, 0x00, 0xff, 0xff, 0xfd, 0xb1, 0x23, 0xed, 0xf5, 0x00, 0x00, 0x00,
}
« no previous file with comments | « common/api/logdog_coordinator/services/v1/tasks.proto ('k') | common/api/logdog_coordinator/services/v1/util.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698