Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1863883002: DevTools: Fix first paint screenshot. (Closed)

Created:
4 years, 8 months ago by alph
Modified:
4 years, 8 months ago
Reviewers:
caseq, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Fix first paint screenshot. Do not propagate screenshots back in time. BUG=600158 Committed: https://crrev.com/935849ed04e5eb6473beecde6d261b1a9486b7a5 Cr-Commit-Position: refs/heads/master@{#385389}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -49 lines) Patch
M third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripModel.js View 1 chunk +2 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js View 5 chunks +10 lines, -27 lines 1 comment Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/TimelineOverviewPane.js View 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
alph
4 years, 8 months ago (2016-04-05 23:51:34 UTC) #2
pfeldman
lgtm
4 years, 8 months ago (2016-04-05 23:52:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863883002/1
4 years, 8 months ago (2016-04-05 23:52:51 UTC) #6
caseq
lgtm https://codereview.chromium.org/1863883002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js (right): https://codereview.chromium.org/1863883002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js#newcode469 third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js:469: this._emptyImage = new Image(image.naturalWidth * popoverScale, image.naturalHeight * ...
4 years, 8 months ago (2016-04-06 00:00:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/200100)
4 years, 8 months ago (2016-04-06 05:54:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863883002/1
4 years, 8 months ago (2016-04-06 05:56:04 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 06:57:28 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 06:59:20 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/935849ed04e5eb6473beecde6d261b1a9486b7a5
Cr-Commit-Position: refs/heads/master@{#385389}

Powered by Google App Engine
This is Rietveld 408576698