third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripModel.js - Issue 1863883002: DevTools: Fix first paint screenshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripModel.js

Issue 1863883002: DevTools: Fix first paint screenshot. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js » ('j') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripModel.js b/third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripModel.js

index 362b0c710146da0fb1f214de64d41eb1d4115735..c335527d8700d535a4f28edef2032a211a75d772 100644

--- a/third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripModel.js

@@ -71,17 +71,8 @@ WebInspector.FilmStripModel.prototype = {

frameByTimestamp: function(timestamp)

{

- /**

- * @param {number} timestamp

- * @param {!WebInspector.FilmStripModel.Frame} frame

- * @return {number}

- */

- function comparator(timestamp, frame)

- {

- return timestamp - frame.timestamp;

- }

- var index = this._frames.lowerBound(timestamp, comparator);

- return index < this._frames.length ? this._frames[index] : null;

+ var index = this._frames.upperBound(timestamp, (timestamp, frame) => timestamp - frame.timestamp) - 1;

+ return index >= 0 ? this._frames[index] : null;

}