Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1863803002: Validation of `@required` params (#26182). (Closed)

Created:
4 years, 8 months ago by pquitslund
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -1 line) Patch
M pkg/analyzer/lib/dart/element/element.dart View 2 chunks +11 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 4 chunks +33 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/handle.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/member.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 2 chunks +12 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 3 chunks +48 lines, -0 lines 2 comments Download
M pkg/analyzer/test/generated/hint_code_test.dart View 2 chunks +103 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
pquitslund
4 years, 8 months ago (2016-04-05 22:53:21 UTC) #2
Brian Wilkerson
lgtm https://codereview.chromium.org/1863803002/diff/1/pkg/analyzer/lib/src/generated/error_verifier.dart File pkg/analyzer/lib/src/generated/error_verifier.dart (right): https://codereview.chromium.org/1863803002/diff/1/pkg/analyzer/lib/src/generated/error_verifier.dart#newcode3744 pkg/analyzer/lib/src/generated/error_verifier.dart:3744: reason ??= constantValue.getField('reason')?.toStringValue(); reason will never be null ...
4 years, 8 months ago (2016-04-05 23:27:35 UTC) #3
pquitslund
Thanks! https://codereview.chromium.org/1863803002/diff/1/pkg/analyzer/lib/src/generated/error_verifier.dart File pkg/analyzer/lib/src/generated/error_verifier.dart (right): https://codereview.chromium.org/1863803002/diff/1/pkg/analyzer/lib/src/generated/error_verifier.dart#newcode3744 pkg/analyzer/lib/src/generated/error_verifier.dart:3744: reason ??= constantValue.getField('reason')?.toStringValue(); On 2016/04/05 23:27:35, Brian Wilkerson ...
4 years, 8 months ago (2016-04-06 00:04:13 UTC) #4
scheglov
LGTM
4 years, 8 months ago (2016-04-06 00:46:53 UTC) #5
pquitslund
4 years, 8 months ago (2016-04-06 13:09:18 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6a430d0730ec42f00caf15698c9f894d74355fa6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698