Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: pkg/analyzer/lib/src/dart/element/element.dart

Issue 1863803002: Validation of `@required` params (#26182). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/dart/element/element.dart
diff --git a/pkg/analyzer/lib/src/dart/element/element.dart b/pkg/analyzer/lib/src/dart/element/element.dart
index 01da784f14b23bd973e8dbdac1d34cc10179fd39..ba28157e559fc2fe94a66203ca79c4abd494da30 100644
--- a/pkg/analyzer/lib/src/dart/element/element.dart
+++ b/pkg/analyzer/lib/src/dart/element/element.dart
@@ -1649,6 +1649,17 @@ class ElementAnnotationImpl implements ElementAnnotation {
static String PROXY_VARIABLE_NAME = "proxy";
/**
+ * The name of the class used to mark a parameter as being required.
+ */
+ static String _REQUIRED_CLASS_NAME = "Required";
+
+ /**
+ * The name of the top-level variable used to mark a parameter as being
+ * required.
+ */
+ static String _REQUIRED_VARIABLE_NAME = "required";
+
+ /**
* The element representing the field, variable, or constructor being used as
* an annotation.
*/
@@ -1720,6 +1731,15 @@ class ElementAnnotationImpl implements ElementAnnotation {
element.name == PROXY_VARIABLE_NAME &&
element.library?.isDartCore == true;
+ @override
+ bool get isRequired =>
+ element is ConstructorElement &&
+ element.enclosingElement.name == _REQUIRED_CLASS_NAME &&
+ element.library?.name == _META_LIB_NAME ||
+ element is PropertyAccessorElement &&
+ element.name == _REQUIRED_VARIABLE_NAME &&
+ element.library?.name == _META_LIB_NAME;
+
/**
* Get the library containing this annotation.
*/
@@ -1935,6 +1955,16 @@ abstract class ElementImpl implements Element {
bool get isPublic => !isPrivate;
@override
+ bool get isRequired {
+ for (ElementAnnotation annotation in metadata) {
+ if (annotation.isRequired) {
+ return true;
+ }
+ }
+ return false;
+ }
+
+ @override
bool get isSynthetic => hasModifier(Modifier.SYNTHETIC);
@override
@@ -4093,6 +4123,9 @@ class MultiplyDefinedElementImpl implements MultiplyDefinedElement {
bool get isPublic => !isPrivate;
@override
+ bool get isRequired => false;
+
+ @override
bool get isSynthetic => true;
@override

Powered by Google App Engine
This is Rietveld 408576698