Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 1863753002: Remove ENABLE(OILPAN) uses in wtf/ (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, blink-reviews-wtf_chromium.org, kouhei+heap_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ENABLE(OILPAN) uses in wtf/ R= BUG=585328 Committed: https://crrev.com/309f06d0593c42eb1eaeedc999be4a5b8c05d39c Cr-Commit-Position: refs/heads/master@{#385411}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Sync PartitionAlloc documentation #

Patch Set 3 : More comment syncing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -114 lines) Patch
M third_party/WebKit/Source/wtf/Deque.h View 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/wtf/HashCountedSet.h View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/wtf/HashMap.h View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/wtf/HashSet.h View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/wtf/HashTable.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/wtf/LinkedHashSet.h View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/wtf/ListHashSet.h View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/wtf/PartitionAlloc.md View 1 5 chunks +12 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/wtf/Partitions.h View 1 2 5 chunks +6 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/wtf/Partitions.cpp View 5 chunks +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/wtf/Vector.h View 3 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
sof
please take a look.
4 years, 8 months ago (2016-04-05 21:01:08 UTC) #2
haraken
LGTM https://codereview.chromium.org/1863753002/diff/1/third_party/WebKit/Source/wtf/Partitions.h File third_party/WebKit/Source/wtf/Partitions.h (right): https://codereview.chromium.org/1863753002/diff/1/third_party/WebKit/Source/wtf/Partitions.h#newcode134 third_party/WebKit/Source/wtf/Partitions.h:134: // - Node partition: A partition to allocate ...
4 years, 8 months ago (2016-04-05 23:32:16 UTC) #4
sof
https://codereview.chromium.org/1863753002/diff/1/third_party/WebKit/Source/wtf/Partitions.h File third_party/WebKit/Source/wtf/Partitions.h (right): https://codereview.chromium.org/1863753002/diff/1/third_party/WebKit/Source/wtf/Partitions.h#newcode134 third_party/WebKit/Source/wtf/Partitions.h:134: // - Node partition: A partition to allocate Nodes. ...
4 years, 8 months ago (2016-04-06 05:16:27 UTC) #5
haraken
On 2016/04/06 05:16:27, sof wrote: > https://codereview.chromium.org/1863753002/diff/1/third_party/WebKit/Source/wtf/Partitions.h > File third_party/WebKit/Source/wtf/Partitions.h (right): > > https://codereview.chromium.org/1863753002/diff/1/third_party/WebKit/Source/wtf/Partitions.h#newcode134 > ...
4 years, 8 months ago (2016-04-06 05:18:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863753002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863753002/40001
4 years, 8 months ago (2016-04-06 06:35:43 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-06 09:04:05 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 09:05:18 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/309f06d0593c42eb1eaeedc999be4a5b8c05d39c
Cr-Commit-Position: refs/heads/master@{#385411}

Powered by Google App Engine
This is Rietveld 408576698