Remove ENABLE(OILPAN) uses in wtf/

third_party/WebKit/Source/wtf/Partitions.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 44 matching lines @@
     }
 
     ALWAYS_INLINE static PartitionRootGeneric* fastMallocPartition()
     {
         ASSERT(s_initialized);
         return m_fastMallocAllocator.root();
     }
 
     ALWAYS_INLINE static PartitionRoot* nodePartition()
     {
-#if ENABLE(OILPAN)
         ASSERT_NOT_REACHED();
         return nullptr;
-#else
-        ASSERT(s_initialized);
-        return m_nodeAllocator.root();
-#endif
     }
     ALWAYS_INLINE static PartitionRoot* layoutPartition()
     {
         ASSERT(s_initialized);
         return m_layoutAllocator.root();
     }
 
     static size_t currentDOMMemoryUsage()
     {
         ASSERT(s_initialized);
-#if ENABLE(OILPAN)
         ASSERT_NOT_REACHED();
         return 0;
-#else
-        return m_nodeAllocator.root()->totalSizeOfCommittedPages;
-#endif
     }
 
     static size_t totalSizeOfCommittedPages()
     {
         size_t totalSize = 0;
         totalSize += m_fastMallocAllocator.root()->totalSizeOfCommittedPages;
         totalSize += m_bufferAllocator.root()->totalSizeOfCommittedPages;
-#if !ENABLE(OILPAN)
-        totalSize += m_nodeAllocator.root()->totalSizeOfCommittedPages;
-#endif
         totalSize += m_layoutAllocator.root()->totalSizeOfCommittedPages;
         return totalSize;
     }
 
     static void decommitFreeableMemory();
 
     static void reportMemoryUsageHistogram();
 
     static void dumpMemoryStats(bool isLightDump, PartitionStatsDumper*);
 
@@ skipping 28 matching lines @@
         partitionFreeGeneric(Partitions::fastMallocPartition(), p);
     }
 
     static void handleOutOfMemory();
 
 private:
     static SpinLock s_initializationLock;
     static bool s_initialized;
 
     // We have the following four partitions.
     //   - Node partition: A partition to allocate Nodes. We prepare a

[haraken, 2016/04/05 23:32:16]

Update this comment & PartitionAlloc.md.

[sof, 2016/04/06 05:16:27]

Thanks, updated - I updated a couple of the remarks concerning Node to be over
LayoutObject instead. I think they hold, but please double check.

     //     dedicated partition for Nodes because Nodes are likely to be
     //     a source of use-after-frees. Another reason is for performance:
     //     Since Nodes are guaranteed to be used only by the main
     //     thread, we can bypass acquiring a lock. Also we can improve memory
     //     locality by putting Nodes together.
     //   - Layout object partition: A partition to allocate LayoutObjects.
     //     we prepare a dedicated partition for the same reason as Nodes.
     //   - Buffer partition: A partition to allocate objects that have a strong
     //     risk where the length and/or the contents are exploited from user
     //     scripts. Vectors, HashTables, ArrayBufferContents and Strings are
     //     allocated in the buffer partition.
     //   - Fast malloc partition: A partition to allocate all other objects.
     static PartitionAllocatorGeneric m_fastMallocAllocator;
     static PartitionAllocatorGeneric m_bufferAllocator;
-#if !ENABLE(OILPAN)
-    static SizeSpecificPartitionAllocator<3328> m_nodeAllocator;
-#endif
     static SizeSpecificPartitionAllocator<1024> m_layoutAllocator;
     static ReportPartitionAllocSizeFunction m_reportSizeFunction;
 };
 
 } // namespace WTF
 
 #endif // Partitions_h