Use Finch flag instead of command line for Expect CT reporting

Use Finch flag instead of command line for Expect CT reporting

The Finch flag will let us control roll-out dynamically and turn it off
if necessary.

BUG=600768
Committed: https://crrev.com/9987060bd5cab9a24c78b4d7cbd81a66270c15ce
Cr-Commit-Position: refs/heads/master@{#385266}

[estark, 2016-04-05 17:58:53]

estark@chromium.org changed reviewers:
+ meacer@chromium.org

[estark, 2016-04-05 17:58:54]

meacer, PTAL?

[meacer, 2016-04-05 18:08:40]

Lgtm

https://codereview.chromium.org/1863663002/diff/1/chrome/browser/ssl/chrome_e...
File chrome/browser/ssl/chrome_expect_ct_reporter.cc (right):

https://codereview.chromium.org/1863663002/diff/1/chrome/browser/ssl/chrome_e...
chrome/browser/ssl/chrome_expect_ct_reporter.cc:121: if
(!base::FeatureList::IsEnabled(features::kExpectCTReporting))
This looks new, back in the days when I was young we used 
base::FieldTrialList::FindFullName.

[estark, 2016-04-05 18:10:38]

estark@chromium.org changed reviewers:
+ sky@chromium.org

[estark, 2016-04-05 18:10:39]

sky@, can you please review chrome_features.h and chrome_features.cc?

https://codereview.chromium.org/1863663002/diff/1/chrome/browser/ssl/chrome_e...
File chrome/browser/ssl/chrome_expect_ct_reporter.cc (right):

https://codereview.chromium.org/1863663002/diff/1/chrome/browser/ssl/chrome_e...
chrome/browser/ssl/chrome_expect_ct_reporter.cc:121: if
(!base::FeatureList::IsEnabled(features::kExpectCTReporting))
On 2016/04/05 18:08:40, Mustafa Emre Acer wrote:
> This looks new, back in the days when I was young we used 
> base::FieldTrialList::FindFullName.

Yeah, I think it is new, and it's soooo nice!

[sky, 2016-04-05 19:12:29]

LGTM

[estark, 2016-04-05 19:21:29]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2016-04-05 19:21:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1863663002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1863663002/1

[commit-bot: I haz the power, 2016-04-05 20:02:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-05 20:03:42]

Description was changed from

==========
Use Finch flag instead of command line for Expect CT reporting

The Finch flag will let us control roll-out dynamically and turn it off
if necessary.

BUG=600768
==========

to

==========
Use Finch flag instead of command line for Expect CT reporting

The Finch flag will let us control roll-out dynamically and turn it off
if necessary.

BUG=600768

Committed: https://crrev.com/9987060bd5cab9a24c78b4d7cbd81a66270c15ce
Cr-Commit-Position: refs/heads/master@{#385266}
==========

[commit-bot: I haz the power, 2016-04-05 20:03:43]

Patchset 1 (id:??) landed as
https://crrev.com/9987060bd5cab9a24c78b4d7cbd81a66270c15ce
Cr-Commit-Position: refs/heads/master@{#385266}