Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: chrome/browser/ssl/chrome_expect_ct_reporter.cc

Issue 1863663002: Use Finch flag instead of command line for Expect CT reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/chrome_expect_ct_reporter.cc
diff --git a/chrome/browser/ssl/chrome_expect_ct_reporter.cc b/chrome/browser/ssl/chrome_expect_ct_reporter.cc
index 9e3bd30005336abc24a6f0a3ab5f974aa0f9036f..601800c93ec2edc2a66a1800887a7993f87ea302 100644
--- a/chrome/browser/ssl/chrome_expect_ct_reporter.cc
+++ b/chrome/browser/ssl/chrome_expect_ct_reporter.cc
@@ -8,11 +8,12 @@
#include "base/base64.h"
#include "base/command_line.h"
+#include "base/feature_list.h"
#include "base/json/json_writer.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/stringprintf.h"
#include "base/values.h"
-#include "chrome/common/chrome_switches.h"
+#include "chrome/common/chrome_features.h"
#include "net/url_request/certificate_report_sender.h"
namespace {
@@ -117,10 +118,8 @@ void ChromeExpectCTReporter::OnExpectCTFailed(
if (report_uri.is_empty())
return;
- if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableExpectCTReporting)) {
+ if (!base::FeatureList::IsEnabled(features::kExpectCTReporting))
meacer 2016/04/05 18:08:40 This looks new, back in the days when I was young
estark 2016/04/05 18:10:39 Yeah, I think it is new, and it's soooo nice!
return;
- }
// TODO(estark): De-duplicate reports so that the same report isn't
// sent too often in some period of time.
« no previous file with comments | « chrome/browser/ssl/chrome_expect_ct_reporter.h ('k') | chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698