Convert Site Details to settings-subpage.

Convert Site Details to settings-subpage.

BUG=597314, 543635
Committed: https://crrev.com/5595871a69b34da0b7ba020b9e1d75187179cfb1
Cr-Commit-Position: refs/heads/master@{#385438}

[Finnur, 2016-04-05 15:33:29]

Description was changed from

==========
Convert Site Details to settings-subpage.

BUG=543635
==========

to

==========
Convert Site Details to settings-subpage.

BUG=597314, 543635
==========

[Finnur, 2016-04-05 15:33:29]

finnur@chromium.org changed reviewers:
+ michaelpg@chromium.org

[Finnur, 2016-04-05 15:33:41]

Mind taking a look?

[michaelpg, 2016-04-05 18:22:54]

https://codereview.chromium.org/1863623002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/privacy_page/privacy_page.html (right):

https://codereview.chromium.org/1863623002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/privacy_page/privacy_page.html:222:
site="{{selectedSite}}"
nit: while you're here, since this isn't "notify: true", make it explicitly
1-way bound: site="[[selectedSite]]"

https://codereview.chromium.org/1863623002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/privacy_page/privacy_page.html:223:
current-route="{{currentRoute}}">
is currentRoute used by site-details?

https://codereview.chromium.org/1863623002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_details_permission.js
(right):

https://codereview.chromium.org/1863623002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_details_permission.js:49:
// Finish this asynchronously to give |category| a chance to be set first.
May be preferable to keep this synchronous by making the observer dependent on
|category| being defined:

observers: ['siteChanged_(site, category)']

[Finnur, 2016-04-06 00:25:19]

PTAL

https://codereview.chromium.org/1863623002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/privacy_page/privacy_page.html (right):

https://codereview.chromium.org/1863623002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/privacy_page/privacy_page.html:222:
site="{{selectedSite}}"
Good idea.

https://codereview.chromium.org/1863623002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/privacy_page/privacy_page.html:223:
current-route="{{currentRoute}}">
Hmm... Good catch.

https://codereview.chromium.org/1863623002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_details_permission.js
(right):

https://codereview.chromium.org/1863623002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_details_permission.js:49:
// Finish this asynchronously to give |category| a chance to be set first.
Doh. Of course. Can't believe I overlooked that. Much better solution.

[michaelpg, 2016-04-06 02:20:35]

one typo, otherwise lgtm

https://codereview.chromium.org/1863623002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/privacy_page/privacy_page.html (right):

https://codereview.chromium.org/1863623002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/privacy_page/privacy_page.html:221:
<site-details site="[[selectedSite]]"</site-details>
missing >

[michaelpg, 2016-04-06 06:32:22]

btw, this section represents 58% of the non-meta invisible elements on the
Advanced page (for an empty profile on linux, anyway). Keeping it out of the dom
FTW!

[Finnur, 2016-04-06 10:29:25]

Yay! Thanks. Checking in.

[Finnur, 2016-04-06 10:29:29]

The CQ bit was checked by finnur@chromium.org

[Finnur, 2016-04-06 10:29:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/1863623002/#ps60001
(title: "Address feedback")

[commit-bot: I haz the power, 2016-04-06 10:29:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1863623002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1863623002/60001

[commit-bot: I haz the power, 2016-04-06 11:40:31]

Description was changed from

==========
Convert Site Details to settings-subpage.

BUG=597314, 543635
==========

to

==========
Convert Site Details to settings-subpage.

BUG=597314, 543635
==========

[commit-bot: I haz the power, 2016-04-06 11:40:32]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-06 11:41:42]

Description was changed from

==========
Convert Site Details to settings-subpage.

BUG=597314, 543635
==========

to

==========
Convert Site Details to settings-subpage.

BUG=597314, 543635

Committed: https://crrev.com/5595871a69b34da0b7ba020b9e1d75187179cfb1
Cr-Commit-Position: refs/heads/master@{#385438}
==========

[commit-bot: I haz the power, 2016-04-06 11:41:43]

Patchset 4 (id:??) landed as
https://crrev.com/5595871a69b34da0b7ba020b9e1d75187179cfb1
Cr-Commit-Position: refs/heads/master@{#385438}