chrome/browser/resources/settings/site_settings/site_details_permission.js - Issue 1863623002: Convert Site Details to settings-subpage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/site_details_permission.js

Issue 1863623002: Convert Site Details to settings-subpage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_details.js ('k') | chrome/test/data/webui/settings/site_details_permission_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/site_settings/site_details_permission.js

diff --git a/chrome/browser/resources/settings/site_settings/site_details_permission.js b/chrome/browser/resources/settings/site_settings/site_details_permission.js

index b2f4ce64725c50885d8ce6af5f0a8f42729688b2..5a3fa05f9b5788a18d206265f340fe0d7cdf93a7 100644

--- a/chrome/browser/resources/settings/site_settings/site_details_permission.js

+++ b/chrome/browser/resources/settings/site_settings/site_details_permission.js

@@ -17,10 +17,7 @@ Polymer({

* The site that this widget is showing details for.

* @type {SiteException}

- site: {

- type: Object,

- observer: 'siteChanged_',

- },

+ site: Object,

i18n_: {

readOnly: true,

@@ -34,6 +31,8 @@ Polymer({

+ observers: ['siteChanged_(site, category)'],

/** @override */

attached: function() {

this.addWebUIListener('contentSettingSitePermissionChanged',