components/password_manager/core/browser/password_form_manager.h - Issue 1863533003: Sending a vote that a Password form looks like a SignUp form.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_form_manager.h

Issue 1863533003: Sending a vote that a Password form looks like a SignUp form. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment fix Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/common/password_form.cc ('k') | components/password_manager/core/browser/password_form_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_form_manager.h

diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h

index b855d159a6190cbab9ea43eac97e3dd126b5150e..0cf54a306af532f33ed821eb5060f414baef258d 100644

--- a/components/password_manager/core/browser/password_form_manager.h

+++ b/components/password_manager/core/browser/password_form_manager.h

@@ -542,6 +542,10 @@ class PasswordFormManager : public PasswordStoreConsumer {

// |observed_form_| but also on the credentials that the user submitted.

bool is_possible_change_password_form_without_username_;

+ // True if |provisionally_saved_form_| looks like SignUp form according to

+ // local heuristics.

+ bool does_look_like_signup_form_ = false;

typedef enum {

PRE_MATCHING_PHASE, // Have not yet invoked a GetLogins query to find

// matching login information from password store.