components/autofill/core/common/password_form.cc - Issue 1863533003: Sending a vote that a Password form looks like a SignUp form.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/password_form.cc

Issue 1863533003: Sending a vote that a Password form looks like a SignUp form. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment fix Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/common/password_form.h ('k') | components/password_manager/core/browser/password_form_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/password_form.cc

diff --git a/components/autofill/core/common/password_form.cc b/components/autofill/core/common/password_form.cc

index acb9b45797e2f626b3bef0f5d057c58d0acdc64d..c4bcc588f7686b2a31e15306cd280b9656806393 100644

--- a/components/autofill/core/common/password_form.cc

+++ b/components/autofill/core/common/password_form.cc

@@ -64,6 +64,8 @@ void PasswordFormToJSON(const PasswordForm& form,

target->SetBoolean("was_parsed_using_autofill_predictions",

form.was_parsed_using_autofill_predictions);

target->SetString("affiliated_web_realm", form.affiliated_web_realm);

+ target->SetBoolean("does_look_like_signup_form",

+ form.does_look_like_signup_form);

}

} // namespace

@@ -84,7 +86,8 @@ PasswordForm::PasswordForm()

layout(Layout::LAYOUT_OTHER),

was_parsed_using_autofill_predictions(false),

is_public_suffix_match(false),

- is_affiliation_based_match(false) {}

+ is_affiliation_based_match(false),

+ does_look_like_signup_form(false) {}

PasswordForm::PasswordForm(const PasswordForm& other) = default;

@@ -128,7 +131,8 @@ bool PasswordForm::operator==(const PasswordForm& form) const {

form.was_parsed_using_autofill_predictions &&

is_public_suffix_match == form.is_public_suffix_match &&

is_affiliation_based_match == form.is_affiliation_based_match &&

- affiliated_web_realm == form.affiliated_web_realm;

+ affiliated_web_realm == form.affiliated_web_realm &&

+ does_look_like_signup_form == form.does_look_like_signup_form;

}

bool PasswordForm::operator!=(const PasswordForm& form) const {