chrome/browser/extensions/api/sessions/sessions_api.cc - Issue 186343003: Fix index out of bounds bug which causes memory leak or browser crash in extension sessions API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/sessions/sessions_api.cc

Issue 186343003: Fix index out of bounds bug which causes memory leak or browser crash in extension sessions API. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/sessions/sessions_api.cc

===================================================================

--- chrome/browser/extensions/api/sessions/sessions_api.cc (revision 254429)

+++ chrome/browser/extensions/api/sessions/sessions_api.cc (working copy)

@@ -229,7 +229,8 @@

int selected_index) {

std::string session_id = SessionId(session_tag, tab.tab_id.id()).ToString();

return CreateTabModelHelper(GetProfile(),

- tab.navigations[tab.current_navigation_index],

+ tab.navigations[

+ tab.normalized_navigation_index()],

session_id,

tab_index,

tab.pinned,

« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »