Fix index out of bounds bug which causes memory leak or browser crash in extension sessions API.

This is my first commit, and chromium_presubmit is failing. I added my name in the AUTHORS file.

R=kalman@chromium.org
BUG=348395
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256283

[wjywbs, 2014-03-04 02:56:44]

Please check #4 reply in the bug report for details.

BUG=348395

[wjywbs, 2014-03-07 18:02:17]

I added several more reviewers to this issue. Thanks.

[not at google - send to devlin, 2014-03-07 21:21:45]

https://codereview.chromium.org/186343003/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/sessions/sessions_api.cc (right):

https://codereview.chromium.org/186343003/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/sessions/sessions_api.cc:234:
tab.navigations[index_corrected],
it looks like you can use tab.normalized_navigation_index() here:

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ses...

[earthdok, 2014-03-09 16:47:24]

Sorry, I'm not an appropriate reviewer here. Despite having fixed leaks in this
file before, I'm not familiar with this code.

[wjywbs, 2014-03-11 02:42:15]

PTAL. Thanks.

[not at google - send to devlin, 2014-03-11 02:48:31]

lgtm

[wjywbs, 2014-03-11 05:03:58]

The CQ bit was checked by wjywbs@gmail.com

[commit-bot: I haz the power, 2014-03-11 05:04:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wjywbs@gmail.com/186343003/20001

[wjywbs, 2014-03-11 05:32:52]

The CQ bit was unchecked by wjywbs@gmail.com

[wjywbs, 2014-03-11 05:41:13]

This is my first commit, and chromium_presubmit is failing. I added my name in
the AUTHORS file.

PTAL. Thanks.

[not at google - send to devlin, 2014-03-11 15:17:51]

lgtm

[wjywbs, 2014-03-11 15:35:53]

The CQ bit was checked by wjywbs@gmail.com

[commit-bot: I haz the power, 2014-03-11 15:38:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wjywbs@gmail.com/186343003/40001

[commit-bot: I haz the power, 2014-03-11 18:52:22]

Change committed as 256283

[wjywbs, 2014-03-11 19:13:59]

Hello kalman,

I just found out that the description went to be the commit message:
https://src.chromium.org/viewvc/chrome?revision=256283&view=revision

Is there a way to edit that commit message? Sorry for the mess. I will get
familiar to this process.

Thanks.

[not at google - send to devlin, 2014-03-11 19:22:03]

No you can't change it, but that's ok. The commit message doesn't look out of
place.