third_party/WebKit/LayoutTests/http/tests/preload/document-write/document_write_preload.html - Issue 1863413005: Use a virtual test suite for DocumentWriteEvaluator layout tests

Unified Diff: third_party/WebKit/LayoutTests/http/tests/preload/document-write/document_write_preload.html

Issue 1863413005: Use a virtual test suite for DocumentWriteEvaluator layout tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Expect just failure for non virtual doc write tests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/TestExpectations ('K') | « third_party/WebKit/LayoutTests/VirtualTestSuites ('k') | third_party/WebKit/LayoutTests/http/tests/preload/document_write_preload.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/preload/document-write/document_write_preload.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/preload/document-write/document_write_preload.html b/third_party/WebKit/LayoutTests/http/tests/preload/document-write/document_write_preload.html

new file mode 100644

index 0000000000000000000000000000000000000000..4474a7f680ddb0a06c39e4077925f8c79d6b58c6

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/http/tests/preload/document-write/document_write_preload.html

@@ -0,0 +1,26 @@

+<!DOCTYPE html>

+<script src="../../resources/testharness.js"></script>

+<script src="../../resources/testharnessreport.js"></script>

+<script>

+var t = async_test('Simple scripts that inject external scripts via document.write should be preloaded');

+// We reject scripts with "for", so rename window.performance.

+window.perf = window.performance;

+</script>

+<script>

+if (window.perf)

+ var boundedStart = window.perf.now();

+var src = '../../resources/dummy.js';

+document.write('<scr' + 'ipt src="' + src + '"></scr' + 'ipt>');

+</script>

+<script>

+window.addEventListener("load", t.step_func(function() {

+ window.performance.getEntriesByType('resource').forEach(function(r) {

+ if (r.name.indexOf('dummy.js') != -1) {

+ assert_less_than(r.startTime, boundedStart);

jkarlin 2016/04/08 16:27:43 Can this test flake? What guarantee is there that

Charlie Harrison 2016/04/08 16:33:34 I guess not a hard guarantee, but the html parser

jkarlin 2016/04/08 16:45:42 Seems fine as is until troubles arise, the flakine

+ assert_greater_than(r.startTime, 0);

+ t.done();

+ }

+ });

+}));

+</script>