third_party/WebKit/LayoutTests/http/tests/preload/document-write/document_write_preload.html - Issue 1863413005: Use a virtual test suite for DocumentWriteEvaluator layout tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/preload/document-write/document_write_preload.html

Issue 1863413005: Use a virtual test suite for DocumentWriteEvaluator layout tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Expect just failure for non virtual doc write tests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/TestExpectations ('K') | « third_party/WebKit/LayoutTests/VirtualTestSuites ('k') | third_party/WebKit/LayoutTests/http/tests/preload/document_write_preload.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script>

	5 var t = async_test('Simple scripts that inject external scripts via document.wri te should be preloaded');

	6 // We reject scripts with "for", so rename window.performance.

	7 window.perf = window.performance;

	8 </script>

	9 <script>

	10 if (window.perf)

	11 var boundedStart = window.perf.now();

	12 var src = '../../resources/dummy.js';

	13 document.write('<scr' + 'ipt src="' + src + '"></scr' + 'ipt>');

	14 </script>

	15 <script>

	16 window.addEventListener("load", t.step_func(function() {

	17 window.performance.getEntriesByType('resource').forEach(function(r) {

	18 if (r.name.indexOf('dummy.js') != -1) {

	19 assert_less_than(r.startTime, boundedStart);
	jkarlin 2016/04/08 16:27:43 Can this test flake? What guarantee is there that Can this test flake? What guarantee is there that the preparser will have started on this before boundedStart is set? Charlie Harrison 2016/04/08 16:33:34 I guess not a hard guarantee, but the html parser Show quoted text On 2016/04/08 at 16:27:43, jkarlin wrote: > Can this test flake? What guarantee is there that the preparser will have started on this before boundedStart is set? I guess not a hard guarantee, but the html parser will have to fully fetch and evaluate the testharness.js files before the background parser does the scan. I could always add a delay script if we want to be sure. jkarlin 2016/04/08 16:45:42 Seems fine as is until troubles arise, the flakine Show quoted text On 2016/04/08 16:33:34, csharrison wrote: > On 2016/04/08 at 16:27:43, jkarlin wrote: > > Can this test flake? What guarantee is there that the preparser will have > started on this before boundedStart is set? > > I guess not a hard guarantee, but the html parser will have to fully fetch and > evaluate the testharness.js files before the background parser does the scan. > > I could always add a delay script if we want to be sure. Seems fine as is until troubles arise, the flakiness dashboard looks clean. You might want to add a comment that this could flake though.
	20 assert_greater_than(r.startTime, 0);

	21 t.done();

	22 }

	23 });

	24 }));

	25 </script>

	26

OLD	NEW