Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1528)

Unified Diff: chrome/browser/android/ntp/most_visited_sites.cc

Issue 1863393007: NTP: Fix "Undo" option of the "Item removed" snackbar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/ntp/most_visited_sites.cc
diff --git a/chrome/browser/android/ntp/most_visited_sites.cc b/chrome/browser/android/ntp/most_visited_sites.cc
index aa7f5dd140f5541974baf0d05bdaa8e50ac35c14..e5305e05cdc3d2362e9a12d3148e549687babaaf 100644
--- a/chrome/browser/android/ntp/most_visited_sites.cc
+++ b/chrome/browser/android/ntp/most_visited_sites.cc
@@ -635,7 +635,10 @@ void MostVisitedSites::SaveNewNTPSuggestions(
popular_sites_suggestions.size();
std::vector<std::string> old_sites_url;
std::vector<bool> old_sites_is_personal;
- GetPreviousNTPSites(num_actual_tiles, &old_sites_url, &old_sites_is_personal);
+ // TODO(treib): We used to call |GetPreviousNTPSites| here to populate
+ // |old_sites_url| and |old_sites_is_personal|, but that caused problems
+ // (crbug.com/585391). Either figure out a way to fix them and re-enable,
+ // or properly remove the order-persisting code. crbug.com/601734
MostVisitedSites::SuggestionsVector merged_suggestions = MergeSuggestions(
personal_suggestions, &whitelist_suggestions, &popular_sites_suggestions,
old_sites_url, old_sites_is_personal);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698