[NTP Snippets] Re-fetch snippets on ML changes only when the hosts actually change

[NTP Snippets] Re-fetch snippets on ML changes only when the hosts actually change

Every time the NTP is opened, the suggestions are refreshed, resulting in an OnSuggestionsChanged call.
Instead of blindly re-fetching snippets each time, store the list of hosts we saw previously, and only re-fetch when those change.

BUG=601034
Committed: https://crrev.com/9b08521135f70763c671ea87c6d792c82b690b79
Cr-Commit-Position: refs/heads/master@{#386023}

[Marc Treib, 2016-04-06 16:14:54]

treib@chromium.org changed reviewers:
+ bauerb@chromium.org

[Marc Treib, 2016-04-06 16:14:55]

PTAL!

https://codereview.chromium.org/1863133003/diff/1/components/ntp_snippets/ntp...
File components/ntp_snippets/ntp_snippets_service.cc (right):

https://codereview.chromium.org/1863133003/diff/1/components/ntp_snippets/ntp...
components/ntp_snippets/ntp_snippets_service.cc:230: return
!std::binary_search(hosts.begin(), hosts.end(),
Side-effect of the hosts now being sorted :)

[Bernhard Bauer, 2016-04-07 12:28:12]

https://codereview.chromium.org/1863133003/diff/1/components/ntp_snippets/ntp...
File components/ntp_snippets/ntp_snippets_service.cc (right):

https://codereview.chromium.org/1863133003/diff/1/components/ntp_snippets/ntp...
components/ntp_snippets/ntp_snippets_service.cc:230: return
!std::binary_search(hosts.begin(), hosts.end(),
On 2016/04/06 16:14:55, Marc Treib wrote:
> Side-effect of the hosts now being sorted :)

Neat! :) But could we make the hosts a set instead?

[Marc Treib, 2016-04-07 13:19:54]

https://codereview.chromium.org/1863133003/diff/1/components/ntp_snippets/ntp...
File components/ntp_snippets/ntp_snippets_service.cc (right):

https://codereview.chromium.org/1863133003/diff/1/components/ntp_snippets/ntp...
components/ntp_snippets/ntp_snippets_service.cc:230: return
!std::binary_search(hosts.begin(), hosts.end(),
On 2016/04/07 12:28:12, Bernhard Bauer wrote:
> On 2016/04/06 16:14:55, Marc Treib wrote:
> > Side-effect of the hosts now being sorted :)
> 
> Neat! :) But could we make the hosts a set instead?

Eh.. sure. Done.

[Marc Treib, 2016-04-08 08:15:32]

On 2016/04/07 13:19:54, Marc Treib wrote:
>
https://codereview.chromium.org/1863133003/diff/1/components/ntp_snippets/ntp...
> File components/ntp_snippets/ntp_snippets_service.cc (right):
> 
>
https://codereview.chromium.org/1863133003/diff/1/components/ntp_snippets/ntp...
> components/ntp_snippets/ntp_snippets_service.cc:230: return
> !std::binary_search(hosts.begin(), hosts.end(),
> On 2016/04/07 12:28:12, Bernhard Bauer wrote:
> > On 2016/04/06 16:14:55, Marc Treib wrote:
> > > Side-effect of the hosts now being sorted :)
> > 
> > Neat! :) But could we make the hosts a set instead?
> 
> Eh.. sure. Done.

Ping! :)

[Bernhard Bauer, 2016-04-08 08:17:34]

Sorry, I thought I had replied to this one. LGTM!

[Marc Treib, 2016-04-08 08:20:06]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2016-04-08 08:20:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1863133003/10001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1863133003/10001

[commit-bot: I haz the power, 2016-04-08 09:08:56]

Committed patchset #2 (id:10001)

[commit-bot: I haz the power, 2016-04-08 09:10:24]

Description was changed from

==========
[NTP Snippets] Re-fetch snippets on ML changes only when the hosts actually
change

Every time the NTP is opened, the suggestions are refreshed, resulting in an
OnSuggestionsChanged call.
Instead of blindly re-fetching snippets each time, store the list of hosts we
saw previously, and only re-fetch when those change.

BUG=601034
==========

to

==========
[NTP Snippets] Re-fetch snippets on ML changes only when the hosts actually
change

Every time the NTP is opened, the suggestions are refreshed, resulting in an
OnSuggestionsChanged call.
Instead of blindly re-fetching snippets each time, store the list of hosts we
saw previously, and only re-fetch when those change.

BUG=601034

Committed: https://crrev.com/9b08521135f70763c671ea87c6d792c82b690b79
Cr-Commit-Position: refs/heads/master@{#386023}
==========

[commit-bot: I haz the power, 2016-04-08 09:10:26]

Patchset 2 (id:??) landed as
https://crrev.com/9b08521135f70763c671ea87c6d792c82b690b79
Cr-Commit-Position: refs/heads/master@{#386023}