components/ntp_snippets/ntp_snippets_fetcher.cc - Issue 1863133003: [NTP Snippets] Re-fetch snippets on ML changes only when the hosts actually change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/ntp_snippets_fetcher.cc

Issue 1863133003: [NTP Snippets] Re-fetch snippets on ML changes only when the hosts actually change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@snippets_thumbnails

Patch Set: s/vector/set/ Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/ntp_snippets/ntp_snippets_fetcher.cc

diff --git a/components/ntp_snippets/ntp_snippets_fetcher.cc b/components/ntp_snippets/ntp_snippets_fetcher.cc

index 10e48b0be5f6ea3201ef03df132996633fa09f68..a757019b7643bc0c6ab228d311928d2a29e681d2 100644

--- a/components/ntp_snippets/ntp_snippets_fetcher.cc

+++ b/components/ntp_snippets/ntp_snippets_fetcher.cc

@@ -66,7 +66,7 @@ NTPSnippetsFetcher::AddCallback(const SnippetsAvailableCallback& callback) {

return callback_list_.Add(callback);

}

-void NTPSnippetsFetcher::FetchSnippets(const std::vector<std::string>& hosts) {

+void NTPSnippetsFetcher::FetchSnippets(const std::set<std::string>& hosts) {

// TODO(treib): What to do if there's already a pending request?

const std::string& key = is_stable_channel_

? google_apis::GetAPIKey()

« no previous file with comments | « components/ntp_snippets/ntp_snippets_fetcher.h ('k') | components/ntp_snippets/ntp_snippets_service.h » ('j') | no next file with comments »