[Password Manager] Call FetchDataFromPasswordStore for new password form manager, if there was no c…

[Password Manager] Call FetchDataFromPasswordStore for new password form manager, if there was no corresponding form manager.

Also removes "manager->set_has_generated_password(true)" in PasswordManager::SetGenerationElementAndReasonForForm, because it is just setting generation element, the password hasn't been generated yet.

BUG=601013
Committed: https://crrev.com/35ecc03672a8405f2fea544dbe846518d1a6e4cf
Cr-Commit-Position: refs/heads/master@{#385762}

[kolos1, 2016-04-06 12:47:33]

kolos@chromium.org changed reviewers:
+ dvadym@chromium.org

[dvadym, 2016-04-06 12:52:47]

Is there some way to test such case?

[kolos1, 2016-04-06 13:50:46]

Patchset #2 (id:20001) has been deleted

[kolos1, 2016-04-06 13:51:02]

On 2016/04/06 12:52:47, dvadym wrote:
> Is there some way to test such case?

Test is added.

[kolos1, 2016-04-06 14:10:33]

Patchset #2 (id:40001) has been deleted

[kolos1, 2016-04-06 14:12:01]

On 2016/04/06 13:51:02, kolos1 wrote:
> On 2016/04/06 12:52:47, dvadym wrote:
> > Is there some way to test such case?
> 
> Test is added.

Test is updated.

[dvadym, 2016-04-07 09:18:19]

LGTM, thanks for fix this.

[kolos1, 2016-04-07 10:48:58]

The CQ bit was checked by kolos@chromium.org

[commit-bot: I haz the power, 2016-04-07 10:49:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1863073002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1863073002/60001

[commit-bot: I haz the power, 2016-04-07 11:45:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 11:45:12]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kolos1, 2016-04-07 15:11:54]

The CQ bit was checked by kolos@chromium.org

[commit-bot: I haz the power, 2016-04-07 15:12:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1863073002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1863073002/60001

[commit-bot: I haz the power, 2016-04-07 15:21:12]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-04-07 15:24:16]

Description was changed from

==========
[Password Manager] Call FetchDataFromPasswordStore for new password form
manager, if there was no corresponding form manager.

Also removes "manager->set_has_generated_password(true)" in
PasswordManager::SetGenerationElementAndReasonForForm, because it is just
setting generation element, the password hasn't been generated yet.

BUG=601013
==========

to

==========
[Password Manager] Call FetchDataFromPasswordStore for new password form
manager, if there was no corresponding form manager.

Also removes "manager->set_has_generated_password(true)" in
PasswordManager::SetGenerationElementAndReasonForForm, because it is just
setting generation element, the password hasn't been generated yet.

BUG=601013

Committed: https://crrev.com/35ecc03672a8405f2fea544dbe846518d1a6e4cf
Cr-Commit-Position: refs/heads/master@{#385762}
==========

[commit-bot: I haz the power, 2016-04-07 15:24:17]

Patchset 2 (id:??) landed as
https://crrev.com/35ecc03672a8405f2fea544dbe846518d1a6e4cf
Cr-Commit-Position: refs/heads/master@{#385762}