components/password_manager/core/browser/password_manager.cc - Issue 1863073002: [Password Manager] Call FetchDataFromPasswordStore for new password form manager, if there was no c…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 1863073002: [Password Manager] Call FetchDataFromPasswordStore for new password form manager, if there was no c… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' of https://chromium.googlesource.com/chromium/src into tumblr_crash Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/password_manager/core/browser/password_manager.cc

diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc

index fcd0c9df57e50477e7f97a852097b5014d4143b4..f4a57505001eae4c7904d1cbee8bdb07918bbfb3 100644

--- a/components/password_manager/core/browser/password_manager.cc

+++ b/components/password_manager/core/browser/password_manager.cc

@@ -215,7 +215,7 @@ void PasswordManager::SetGenerationElementAndReasonForForm(

PasswordFormManager* manager = new PasswordFormManager(

this, client_, driver->AsWeakPtr(), form, ssl_valid);

pending_login_managers_.push_back(manager);

- manager->set_has_generated_password(true);

+ manager->FetchDataFromPasswordStore();

}

void PasswordManager::ProvisionallySavePassword(const PasswordForm& form) {

« no previous file with comments | « no previous file | components/password_manager/core/browser/password_manager_unittest.cc » ('j') | no next file with comments »