Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1862963003: Only handle the first AccountAddedToCookie event in OneClickSigninSyncStarter (Closed)

Created:
4 years, 8 months ago by anthonyvd
Modified:
4 years, 8 months ago
CC:
chromium-reviews, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only handle the first AccountAddedToCookie event in OneClickSigninSyncStarter BUG=601048 Committed: https://crrev.com/a95a409b9f1d29e963de1528220b7c607b45996f Cr-Commit-Position: refs/heads/master@{#385749}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/ui/sync/one_click_signin_sync_starter.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_starter.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
anthonyvd
Hi Roger, can you please look at this fix we discussed offline? Thanks!
4 years, 8 months ago (2016-04-06 15:38:53 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm
4 years, 8 months ago (2016-04-07 14:11:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862963003/1
4 years, 8 months ago (2016-04-07 14:13:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 14:22:08 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 14:23:58 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a95a409b9f1d29e963de1528220b7c607b45996f
Cr-Commit-Position: refs/heads/master@{#385749}

Powered by Google App Engine
This is Rietveld 408576698