Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1344)

Unified Diff: chrome/browser/ui/sync/one_click_signin_sync_starter.h

Issue 1862963003: Only handle the first AccountAddedToCookie event in OneClickSigninSyncStarter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/sync/one_click_signin_sync_starter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/sync/one_click_signin_sync_starter.h
diff --git a/chrome/browser/ui/sync/one_click_signin_sync_starter.h b/chrome/browser/ui/sync/one_click_signin_sync_starter.h
index 5cc33693280cd3b14a79b0756c355bc203ec2cbd..b8b497071adc910c366fb25b2349da0eecd894cf 100644
--- a/chrome/browser/ui/sync/one_click_signin_sync_starter.h
+++ b/chrome/browser/ui/sync/one_click_signin_sync_starter.h
@@ -233,6 +233,11 @@ class OneClickSigninSyncStarter : public SigninTracker::Observer,
std::string dm_token_;
std::string client_id_;
+ // This only cares about the first AccountAddedToCookie event. Since
+ // SigninTracker always expects an observer, this object will just disregard
+ // following AccountAddedToCookie calls triggered by account reconciliation.
+ bool first_account_added_to_cookie_;
+
base::WeakPtrFactory<OneClickSigninSyncStarter> weak_pointer_factory_;
DISALLOW_COPY_AND_ASSIGN(OneClickSigninSyncStarter);
« no previous file with comments | « no previous file | chrome/browser/ui/sync/one_click_signin_sync_starter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698