Issue 1862773002: Suppress some additional msvs warnings (GN).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1862773002: Suppress some additional msvs warnings (GN). (Closed)

Created:
4 years, 8 months ago by Oliver Chang

Modified:
4 years, 8 months ago

Reviewers:
Tom Sepez, Wei Li

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

More Reviews

Description

Suppress some additional msvs warnings (GN). Fixes GN build after 47ca692. R=tsepez@chromium.org,weili@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/e5984e92ff378a86118f1e6428dc325dbde9c409

Patch Set 1 #

Patch Set 2 : ordering nit #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
	M	BUILD.gn	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
	M	third_party/BUILD.gn	View		1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862773002/20001

4 years, 8 months ago (2016-04-05 21:27:28 UTC) #3

commit-bot: I haz the power

4 years, 8 months ago (2016-04-05 21:41:29 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/e5984e92ff378a86118f1e6428dc325dbde9...

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages