Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: third_party/BUILD.gn

Issue 1862773002: Suppress some additional msvs warnings (GN). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: ordering nit Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/BUILD.gn
diff --git a/third_party/BUILD.gn b/third_party/BUILD.gn
index ec6f8cb7f83574c8acc3cff784251258ee98f5a1..f899bd14816801521ee7b77647ec74aedbd7f73b 100644
--- a/third_party/BUILD.gn
+++ b/third_party/BUILD.gn
@@ -252,11 +252,24 @@ source_set("jpeg") {
]
}
+config("fx_libopenjpeg_warnings") {
+ visibility = [ ":*" ]
+ if (is_win) {
+ cflags = [
+ # Signed/unsigned comparisons.
+ "/wd4018",
+ ]
+ }
+}
+
source_set("fx_libopenjpeg") {
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [
"//build/config/compiler:no_chromium_code",
"//third_party/pdfium:pdfium_config",
+
+ # Must be after no_chromium_code for warning flags to be ordered correctly.
+ ":fx_libopenjpeg_warnings",
]
sources = [
"libopenjpeg20/bio.c",
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698