third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.cpp - Issue 1862733002: Remove all use of crop edges from SkImageFilter::CropRect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.cpp

Issue 1862733002: Remove all use of crop edges from SkImageFilter::CropRect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix FEMorphology bug Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp ('K') | « third_party/WebKit/Source/platform/graphics/filters/FEDisplacementMap.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/FEFlood.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.cpp b/third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.cpp

index 5bf275a708e22dc4a6b6eea8fe758a4cdd4f4399..c52f52cc2247cae16a64a539cffac3b73a47cb39 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.cpp

@@ -73,8 +73,8 @@ PassRefPtr<SkImageFilter> FEDropShadow::createImageFilter(SkiaImageFilterBuilder

float stdX = getFilter()->applyHorizontalScale(m_stdX);

float stdY = getFilter()->applyVerticalScale(m_stdY);

Color color = adaptColorToOperatingColorSpace(m_shadowColor.combineWithAlpha(m_shadowOpacity));

- SkImageFilter::CropRect cropRect = getCropRect();

- return adoptRef(SkDropShadowImageFilter::Create(SkFloatToScalar(dx), SkFloatToScalar(dy), SkFloatToScalar(stdX), SkFloatToScalar(stdY), color.rgb(), SkDropShadowImageFilter::kDrawShadowAndForeground_ShadowMode, input.get(), &cropRect));

+ SkImageFilter::CropRect cropRect;

+ return adoptRef(SkDropShadowImageFilter::Create(SkFloatToScalar(dx), SkFloatToScalar(dy), SkFloatToScalar(stdX), SkFloatToScalar(stdY), color.rgb(), SkDropShadowImageFilter::kDrawShadowAndForeground_ShadowMode, input.get(), getCropRect(&cropRect)));

}