third_party/WebKit/Source/platform/graphics/filters/FEComponentTransfer.cpp - Issue 1862733002: Remove all use of crop edges from SkImageFilter::CropRect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FEComponentTransfer.cpp

Issue 1862733002: Remove all use of crop edges from SkImageFilter::CropRect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix FEMorphology bug Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp ('K') | « third_party/WebKit/Source/platform/graphics/filters/FEColorMatrix.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FEComponentTransfer.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FEComponentTransfer.cpp b/third_party/WebKit/Source/platform/graphics/filters/FEComponentTransfer.cpp

index a086b1174d302a22cd096fa4593fd79e877d5c40..5bc10f1523ed7351c582e747b46a1d6bc8521306 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FEComponentTransfer.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FEComponentTransfer.cpp

@@ -135,9 +135,9 @@ PassRefPtr<SkImageFilter> FEComponentTransfer::createImageFilter(SkiaImageFilter

unsigned char rValues[256], gValues[256], bValues[256], aValues[256];

getValues(rValues, gValues, bValues, aValues);

- SkImageFilter::CropRect cropRect = getCropRect();

+ SkImageFilter::CropRect cropRect;

sk_sp<SkColorFilter> colorFilter = SkTableColorFilter::MakeARGB(aValues, rValues, gValues, bValues);

- return adoptRef(SkColorFilterImageFilter::Create(colorFilter.get(), input.get(), &cropRect));

+ return adoptRef(SkColorFilterImageFilter::Create(colorFilter.get(), input.get(), getCropRect(&cropRect)));

}

void FEComponentTransfer::getValues(unsigned char rValues[256], unsigned char gValues[256], unsigned char bValues[256], unsigned char aValues[256])