Convert Coverage flavor and bot to Swarming

Convert Coverage flavor and bot to Swarming.

This CL does the following:
* Convert Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage to use the skia/swarm_trigger recipe and run on skiabot-linux-swarm-013.
* Compile steps are skipped for Coverage bots because the path to the out directory was compiled into the binary, which is why the compile and test steps needed to be combined.
* All coverage GS uploads are now done from the babysitter bot using the swarming outputs.
* Updated specs using the build_spec change in https://codereview.chromium.org/1889183002
* Updated all expectations and tests.

Tested it locally with:
python scripts/tools/run_recipe.py skia/swarm_trigger buildername=Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot slavename=skiabot-linux-swarm-012 mastername=client.skia buildnumber=2 revision=4334ff29b474e3ca6acd6316ae24569eb58550c3 rietveld=https://codereview.chromium.org issue=1858363002 patchset=390001

Resultant working Swarming test_skia task:
https://chromium-swarm.appspot.com/user/task/2e326e6c03ca9210


BUG=skia:5159
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299978

[rmistry, 2016-04-05 18:41:41]

Description was changed from

==========
Add Swarming builder for Coverage and update specs

BUG=skia:5159
==========

to

==========
Add Swarming builder for Coverage and update specs.

Ran it locally with:
python scripts/tools/run_recipe.py skia/swarm_trigger
buildername=Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Swarming-Trybot
slavename=skiabot-linux-swarm-012 mastername=client.skia.fyi buildnumber=2
revision=142659c76dfca1e0a34eb6a022329b73b6ba3166
rietveld=https://codereview.chromium.org issue=1858363002 patchset=1

BUG=skia:5159
==========

[rmistry, 2016-04-14 12:23:24]

Patchset #13 (id:240001) has been deleted

[rmistry, 2016-04-14 12:51:16]

Description was changed from

==========
Add Swarming builder for Coverage and update specs.

Ran it locally with:
python scripts/tools/run_recipe.py skia/swarm_trigger
buildername=Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Swarming-Trybot
slavename=skiabot-linux-swarm-012 mastername=client.skia.fyi buildnumber=2
revision=142659c76dfca1e0a34eb6a022329b73b6ba3166
rietveld=https://codereview.chromium.org issue=1858363002 patchset=1

BUG=skia:5159
==========

to

==========
Add Swarming builder for Coverage and update specs.

Tested it locally with:
python scripts/tools/run_recipe.py skia/swarm_trigger
buildername=Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot
slavename=skiabot-linux-swarm-012 mastername=client.skia buildnumber=2
revision=4334ff29b474e3ca6acd6316ae24569eb58550c3
rietveld=https://codereview.chromium.org issue=1858363002 patchset=330001

Swarming test_skia task:

The results look correct and are available in:
* 
*
*


BUG=skia:5159
==========

[rmistry, 2016-04-15 14:00:52]

Description was changed from

==========
Add Swarming builder for Coverage and update specs.

Tested it locally with:
python scripts/tools/run_recipe.py skia/swarm_trigger
buildername=Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot
slavename=skiabot-linux-swarm-012 mastername=client.skia buildnumber=2
revision=4334ff29b474e3ca6acd6316ae24569eb58550c3
rietveld=https://codereview.chromium.org issue=1858363002 patchset=330001

Swarming test_skia task:

The results look correct and are available in:
* 
*
*


BUG=skia:5159
==========

to

==========
Add Swarming builder for Coverage and update specs.

Tested it locally with:
python scripts/tools/run_recipe.py skia/swarm_trigger
buildername=Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot
slavename=skiabot-linux-swarm-012 mastername=client.skia buildnumber=2
revision=4334ff29b474e3ca6acd6316ae24569eb58550c3
rietveld=https://codereview.chromium.org issue=1858363002 patchset=390001

Swarming test_skia task:

The results look correct and are available in:
* 
*
*


BUG=skia:5159
==========

[rmistry, 2016-04-15 14:02:25]

Description was changed from

==========
Add Swarming builder for Coverage and update specs.

Tested it locally with:
python scripts/tools/run_recipe.py skia/swarm_trigger
buildername=Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot
slavename=skiabot-linux-swarm-012 mastername=client.skia buildnumber=2
revision=4334ff29b474e3ca6acd6316ae24569eb58550c3
rietveld=https://codereview.chromium.org issue=1858363002 patchset=390001

Swarming test_skia task:

The results look correct and are available in:
* 
*
*


BUG=skia:5159
==========

to

==========
Add Swarming builder for Coverage and update specs.

Tested it locally with:
python scripts/tools/run_recipe.py skia/swarm_trigger
buildername=Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot
slavename=skiabot-linux-swarm-012 mastername=client.skia buildnumber=2
revision=4334ff29b474e3ca6acd6316ae24569eb58550c3
rietveld=https://codereview.chromium.org issue=1858363002 patchset=390001

Swarming test_skia task:
https://chromium-swarm.appspot.com/user/task/2e326e6c03ca9210

The results look correct and are available in:
* 
*
*


BUG=skia:5159
==========

[rmistry, 2016-04-15 14:05:45]

Description was changed from

==========
Add Swarming builder for Coverage and update specs.

Tested it locally with:
python scripts/tools/run_recipe.py skia/swarm_trigger
buildername=Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot
slavename=skiabot-linux-swarm-012 mastername=client.skia buildnumber=2
revision=4334ff29b474e3ca6acd6316ae24569eb58550c3
rietveld=https://codereview.chromium.org issue=1858363002 patchset=390001

Swarming test_skia task:
https://chromium-swarm.appspot.com/user/task/2e326e6c03ca9210

The results look correct and are available in:
* 
*
*


BUG=skia:5159
==========

to

==========
Add Swarming builder for Coverage and update specs.

Tested it locally with:
python scripts/tools/run_recipe.py skia/swarm_trigger
buildername=Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot
slavename=skiabot-linux-swarm-012 mastername=client.skia buildnumber=2
revision=4334ff29b474e3ca6acd6316ae24569eb58550c3
rietveld=https://codereview.chromium.org issue=1858363002 patchset=390001

Swarming test_skia task:
https://chromium-swarm.appspot.com/user/task/2e326e6c03ca9210


BUG=skia:5159
==========

[rmistry, 2016-04-15 14:23:25]

Description was changed from

==========
Add Swarming builder for Coverage and update specs.

Tested it locally with:
python scripts/tools/run_recipe.py skia/swarm_trigger
buildername=Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot
slavename=skiabot-linux-swarm-012 mastername=client.skia buildnumber=2
revision=4334ff29b474e3ca6acd6316ae24569eb58550c3
rietveld=https://codereview.chromium.org issue=1858363002 patchset=390001

Swarming test_skia task:
https://chromium-swarm.appspot.com/user/task/2e326e6c03ca9210


BUG=skia:5159
==========

to

==========
Changes required to add Coverage Swarming builder.

This CL does the following:
* Convert Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage to use the
skia/swarm_trigger recipe and run on skiabot-linux-swarm-013.
* Compile steps are skipped for Coverage bots because the path to the out
directory was compiled into the binary, which is why the compile and test steps
needed to be combined.
* All coverage GS uploads are now done from the babysitter bot using the
swarming outputs.
* Updated specs using the build_spec change in
https://codereview.chromium.org/1889183002
* Updated all expectations and tests.



Tested it locally with:
python scripts/tools/run_recipe.py skia/swarm_trigger
buildername=Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot
slavename=skiabot-linux-swarm-012 mastername=client.skia buildnumber=2
revision=4334ff29b474e3ca6acd6316ae24569eb58550c3
rietveld=https://codereview.chromium.org issue=1858363002 patchset=390001

Resultant working Swarming test_skia task:
https://chromium-swarm.appspot.com/user/task/2e326e6c03ca9210


BUG=skia:5159
==========

[rmistry, 2016-04-15 14:23:35]

Description was changed from

==========
Changes required to add Coverage Swarming builder.

This CL does the following:
* Convert Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage to use the
skia/swarm_trigger recipe and run on skiabot-linux-swarm-013.
* Compile steps are skipped for Coverage bots because the path to the out
directory was compiled into the binary, which is why the compile and test steps
needed to be combined.
* All coverage GS uploads are now done from the babysitter bot using the
swarming outputs.
* Updated specs using the build_spec change in
https://codereview.chromium.org/1889183002
* Updated all expectations and tests.



Tested it locally with:
python scripts/tools/run_recipe.py skia/swarm_trigger
buildername=Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot
slavename=skiabot-linux-swarm-012 mastername=client.skia buildnumber=2
revision=4334ff29b474e3ca6acd6316ae24569eb58550c3
rietveld=https://codereview.chromium.org issue=1858363002 patchset=390001

Resultant working Swarming test_skia task:
https://chromium-swarm.appspot.com/user/task/2e326e6c03ca9210


BUG=skia:5159
==========

to

==========
Changes required to add Coverage Swarming builder.

This CL does the following:
* Convert Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage to use the
skia/swarm_trigger recipe and run on skiabot-linux-swarm-013.
* Compile steps are skipped for Coverage bots because the path to the out
directory was compiled into the binary, which is why the compile and test steps
needed to be combined.
* All coverage GS uploads are now done from the babysitter bot using the
swarming outputs.
* Updated specs using the build_spec change in
https://codereview.chromium.org/1889183002
* Updated all expectations and tests.

Tested it locally with:
python scripts/tools/run_recipe.py skia/swarm_trigger
buildername=Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot
slavename=skiabot-linux-swarm-012 mastername=client.skia buildnumber=2
revision=4334ff29b474e3ca6acd6316ae24569eb58550c3
rietveld=https://codereview.chromium.org issue=1858363002 patchset=390001

Resultant working Swarming test_skia task:
https://chromium-swarm.appspot.com/user/task/2e326e6c03ca9210


BUG=skia:5159
==========

[rmistry, 2016-04-15 14:25:22]

Description was changed from

==========
Changes required to add Coverage Swarming builder.

This CL does the following:
* Convert Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage to use the
skia/swarm_trigger recipe and run on skiabot-linux-swarm-013.
* Compile steps are skipped for Coverage bots because the path to the out
directory was compiled into the binary, which is why the compile and test steps
needed to be combined.
* All coverage GS uploads are now done from the babysitter bot using the
swarming outputs.
* Updated specs using the build_spec change in
https://codereview.chromium.org/1889183002
* Updated all expectations and tests.

Tested it locally with:
python scripts/tools/run_recipe.py skia/swarm_trigger
buildername=Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot
slavename=skiabot-linux-swarm-012 mastername=client.skia buildnumber=2
revision=4334ff29b474e3ca6acd6316ae24569eb58550c3
rietveld=https://codereview.chromium.org issue=1858363002 patchset=390001

Resultant working Swarming test_skia task:
https://chromium-swarm.appspot.com/user/task/2e326e6c03ca9210


BUG=skia:5159
==========

to

==========
Convert Coverage flavor and bot to Swarming.

This CL does the following:
* Convert Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage to use the
skia/swarm_trigger recipe and run on skiabot-linux-swarm-013.
* Compile steps are skipped for Coverage bots because the path to the out
directory was compiled into the binary, which is why the compile and test steps
needed to be combined.
* All coverage GS uploads are now done from the babysitter bot using the
swarming outputs.
* Updated specs using the build_spec change in
https://codereview.chromium.org/1889183002
* Updated all expectations and tests.

Tested it locally with:
python scripts/tools/run_recipe.py skia/swarm_trigger
buildername=Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot
slavename=skiabot-linux-swarm-012 mastername=client.skia buildnumber=2
revision=4334ff29b474e3ca6acd6316ae24569eb58550c3
rietveld=https://codereview.chromium.org issue=1858363002 patchset=390001

Resultant working Swarming test_skia task:
https://chromium-swarm.appspot.com/user/task/2e326e6c03ca9210


BUG=skia:5159
==========

[rmistry, 2016-04-15 14:33:36]

rmistry@google.com changed reviewers:
+ borenet@google.com

[borenet, 2016-04-15 16:19:33]

https://codereview.chromium.org/1862713002/diff/360001/scripts/slave/recipe_m...
File scripts/slave/recipe_modules/skia/api.py (right):

https://codereview.chromium.org/1862713002/diff/360001/scripts/slave/recipe_m...
scripts/slave/recipe_modules/skia/api.py:204: self.gsutil_env_skia_infra =
self.gsutil_env(None)
I think we can get rid of this now.

https://codereview.chromium.org/1862713002/diff/360001/scripts/slave/recipe_m...
scripts/slave/recipe_modules/skia/api.py:238: self.compile_steps()
Needs:
if self.do_compile_steps:

https://codereview.chromium.org/1862713002/diff/360001/scripts/slave/recipes/...
File scripts/slave/recipes/skia/swarm_trigger.py (right):

https://codereview.chromium.org/1862713002/diff/360001/scripts/slave/recipes/...
scripts/slave/recipes/skia/swarm_trigger.py:364: if builder_cfg['configuration']
 == 'Coverage':
Please move the below into its own function, preferably in a different file.

[rmistry, 2016-04-15 17:46:55]

Patchset #19 (id:380001) has been deleted

[rmistry, 2016-04-15 17:48:01]

https://codereview.chromium.org/1862713002/diff/360001/scripts/slave/recipe_m...
File scripts/slave/recipe_modules/skia/api.py (right):

https://codereview.chromium.org/1862713002/diff/360001/scripts/slave/recipe_m...
scripts/slave/recipe_modules/skia/api.py:204: self.gsutil_env_skia_infra =
self.gsutil_env(None)
On 2016/04/15 16:19:33, borenet wrote:
> I think we can get rid of this now.

Done.

https://codereview.chromium.org/1862713002/diff/360001/scripts/slave/recipe_m...
scripts/slave/recipe_modules/skia/api.py:238: self.compile_steps()
On 2016/04/15 16:19:33, borenet wrote:
> Needs:
> if self.do_compile_steps:

Done.

https://codereview.chromium.org/1862713002/diff/360001/scripts/slave/recipes/...
File scripts/slave/recipes/skia/swarm_trigger.py (right):

https://codereview.chromium.org/1862713002/diff/360001/scripts/slave/recipes/...
scripts/slave/recipes/skia/swarm_trigger.py:364: if builder_cfg['configuration']
 == 'Coverage':
On 2016/04/15 16:19:33, borenet wrote:
> Please move the below into its own function, preferably in a different file.

Moved into its own function. Couldn't come up with a good file name and maybe it
makes sense to stay in swarm_trigger.

[borenet, 2016-04-15 18:02:40]

LGTM with one nit

https://codereview.chromium.org/1862713002/diff/400001/scripts/slave/recipes/...
File scripts/slave/recipes/skia/swarm_trigger.py (right):

https://codereview.chromium.org/1862713002/diff/400001/scripts/slave/recipes/...
scripts/slave/recipes/skia/swarm_trigger.py:368: def coverage_steps_collect(api,
task, got_revision, is_trybot):
Nit: I think "upload_coverage_results" Is a better name for this, since we've
already collected the results of the swarming task.

[rmistry, 2016-04-15 18:06:58]

I plan to submit all CLs on Monday morning.

https://codereview.chromium.org/1862713002/diff/400001/scripts/slave/recipes/...
File scripts/slave/recipes/skia/swarm_trigger.py (right):

https://codereview.chromium.org/1862713002/diff/400001/scripts/slave/recipes/...
scripts/slave/recipes/skia/swarm_trigger.py:368: def coverage_steps_collect(api,
task, got_revision, is_trybot):
On 2016/04/15 18:02:39, borenet wrote:
> Nit: I think "upload_coverage_results" Is a better name for this, since we've
> already collected the results of the swarming task.

Done.

[rmistry, 2016-04-18 10:49:55]

The CQ bit was checked by rmistry@google.com

[rmistry, 2016-04-18 10:49:55]

The patchset sent to the CQ was uploaded after l-g-t-m from borenet@google.com
Link to the patchset: https://codereview.chromium.org/1862713002/#ps420001
(title: "Rename")

[commit-bot: I haz the power, 2016-04-18 10:50:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1862713002/420001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1862713002/420001

[commit-bot: I haz the power, 2016-04-18 10:50:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-18 10:50:05]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[rmistry1, 2016-04-18 10:50:43]

rmistry@chromium.org changed reviewers:
+ rmistry@chromium.org

[rmistry1, 2016-04-18 10:50:45]

lgtm

[rmistry, 2016-04-18 10:51:01]

The CQ bit was checked by rmistry@google.com

[commit-bot: I haz the power, 2016-04-18 10:51:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1862713002/420001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1862713002/420001

[commit-bot: I haz the power, 2016-04-18 10:55:13]

Description was changed from

==========
Convert Coverage flavor and bot to Swarming.

This CL does the following:
* Convert Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage to use the
skia/swarm_trigger recipe and run on skiabot-linux-swarm-013.
* Compile steps are skipped for Coverage bots because the path to the out
directory was compiled into the binary, which is why the compile and test steps
needed to be combined.
* All coverage GS uploads are now done from the babysitter bot using the
swarming outputs.
* Updated specs using the build_spec change in
https://codereview.chromium.org/1889183002
* Updated all expectations and tests.

Tested it locally with:
python scripts/tools/run_recipe.py skia/swarm_trigger
buildername=Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot
slavename=skiabot-linux-swarm-012 mastername=client.skia buildnumber=2
revision=4334ff29b474e3ca6acd6316ae24569eb58550c3
rietveld=https://codereview.chromium.org issue=1858363002 patchset=390001

Resultant working Swarming test_skia task:
https://chromium-swarm.appspot.com/user/task/2e326e6c03ca9210


BUG=skia:5159
==========

to

==========
Convert Coverage flavor and bot to Swarming.

This CL does the following:
* Convert Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage to use the
skia/swarm_trigger recipe and run on skiabot-linux-swarm-013.
* Compile steps are skipped for Coverage bots because the path to the out
directory was compiled into the binary, which is why the compile and test steps
needed to be combined.
* All coverage GS uploads are now done from the babysitter bot using the
swarming outputs.
* Updated specs using the build_spec change in
https://codereview.chromium.org/1889183002
* Updated all expectations and tests.

Tested it locally with:
python scripts/tools/run_recipe.py skia/swarm_trigger
buildername=Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot
slavename=skiabot-linux-swarm-012 mastername=client.skia buildnumber=2
revision=4334ff29b474e3ca6acd6316ae24569eb58550c3
rietveld=https://codereview.chromium.org issue=1858363002 patchset=390001

Resultant working Swarming test_skia task:
https://chromium-swarm.appspot.com/user/task/2e326e6c03ca9210


BUG=skia:5159

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299978
==========

[commit-bot: I haz the power, 2016-04-18 10:55:14]

Committed patchset #20 (id:420001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299978