Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1889183002:
Do not do compile steps for Coverage (Closed)
DescriptionDo not do compile steps for Coverage
Coverage needs to do compilation in its test step. The primary reason is: the path to the out directory is compiled into the binary, which is why the compile and test steps need to be combined.
BUG=skia:5159
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1889183002
NOTREECHECKS=true
Committed: https://skia.googlesource.com/skia/+/43e8f6725457a70bbadf7cba82fd162960464b99
Patch Set 1 : Initial upload #
Messages
Total messages: 17 (10 generated)
Description was changed from ========== Do not do compile steps for Coverage Coverage does not need a separate compile step because it needs to do compilation in its test step. The primary reason is: the path to the out directory is compiled into the binary, which is why the compile and test steps need to be combined. BUG=skia:5159 ========== to ========== Do not do compile steps for Coverage Coverage does not need a separate compile step because it needs to do compilation in its test step. The primary reason is: the path to the out directory is compiled into the binary, which is why the compile and test steps need to be combined. BUG=skia:5159 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by rmistry@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889183002/1
Description was changed from ========== Do not do compile steps for Coverage Coverage does not need a separate compile step because it needs to do compilation in its test step. The primary reason is: the path to the out directory is compiled into the binary, which is why the compile and test steps need to be combined. BUG=skia:5159 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Do not do compile steps for Coverage Coverage needs to do compilation in its test step. The primary reason is: the path to the out directory is compiled into the binary, which is why the compile and test steps need to be combined. BUG=skia:5159 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
rmistry@google.com changed reviewers: + borenet@google.com
LGTM
The CQ bit was checked by rmistry@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889183002/1
Description was changed from ========== Do not do compile steps for Coverage Coverage needs to do compilation in its test step. The primary reason is: the path to the out directory is compiled into the binary, which is why the compile and test steps need to be combined. BUG=skia:5159 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Do not do compile steps for Coverage Coverage needs to do compilation in its test step. The primary reason is: the path to the out directory is compiled into the binary, which is why the compile and test steps need to be combined. BUG=skia:5159 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... NOTREECHECKS=true ==========
The CQ bit was unchecked by rmistry@google.com
The CQ bit was checked by rmistry@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889183002/1
Message was sent while issue was closed.
Description was changed from ========== Do not do compile steps for Coverage Coverage needs to do compilation in its test step. The primary reason is: the path to the out directory is compiled into the binary, which is why the compile and test steps need to be combined. BUG=skia:5159 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... NOTREECHECKS=true ========== to ========== Do not do compile steps for Coverage Coverage needs to do compilation in its test step. The primary reason is: the path to the out directory is compiled into the binary, which is why the compile and test steps need to be combined. BUG=skia:5159 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/43e8f6725457a70bbadf7cba82fd162960464b99 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/43e8f6725457a70bbadf7cba82fd162960464b99 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
