Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1862653002: Move MemoryAllocator and CodeRange into Heap (Closed)

Created:
4 years, 8 months ago by Michael Lippautz
Modified:
4 years, 8 months ago
CC:
Hannes Payer (out of office), v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move MemoryAllocator and CodeRange into Heap - MemoryAllocator is now part of Heap - CodeRange is now part of MemoryAllocator BUG=chromium:581076 LOG=N Committed: https://crrev.com/6a5e24b29b4438185ed04663794962274501c478 Cr-Commit-Position: refs/heads/master@{#35294}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -162 lines) Patch
M src/api.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M src/extensions/statistics-extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/heap/gc-tracer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap/heap.h View 1 3 chunks +5 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 20 chunks +32 lines, -26 lines 0 comments Download
M src/heap/spaces.h View 1 4 chunks +8 lines, -1 line 0 comments Download
M src/heap/spaces.cc View 1 20 chunks +39 lines, -40 lines 0 comments Download
M src/heap/spaces-inl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.h View 5 chunks +0 lines, -9 lines 0 comments Download
M src/isolate.cc View 5 chunks +1 line, -10 lines 0 comments Download
M src/regexp/jsregexp.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/assembler-x64-inl.h View 2 chunks +4 lines, -2 lines 0 comments Download
M test/cctest/heap/test-spaces.cc View 8 chunks +59 lines, -61 lines 0 comments Download

Depends on Patchset:

Issue 1851733002 Patch 1

Messages

Total messages: 29 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862653002/1
4 years, 8 months ago (2016-04-05 15:32:13 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-05 15:57:24 UTC) #5
Michael Lippautz
4 years, 8 months ago (2016-04-06 07:05:57 UTC) #7
Hannes Payer (out of office)
lgtm
4 years, 8 months ago (2016-04-06 09:13:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862653002/1
4 years, 8 months ago (2016-04-06 09:27:05 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/13278)
4 years, 8 months ago (2016-04-06 09:29:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862653002/1
4 years, 8 months ago (2016-04-06 09:32:36 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/13281)
4 years, 8 months ago (2016-04-06 09:36:27 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862653002/20001
4 years, 8 months ago (2016-04-06 09:44:36 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-06 10:12:25 UTC) #20
Michael Lippautz
+ulan for regexp/ stamp
4 years, 8 months ago (2016-04-06 10:36:53 UTC) #22
ulan
On 2016/04/06 at 10:36:53, mlippautz wrote: > +ulan for regexp/ stamp regexp lgtm
4 years, 8 months ago (2016-04-06 10:38:34 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862653002/20001
4 years, 8 months ago (2016-04-06 10:54:22 UTC) #26
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-06 11:38:36 UTC) #27
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 11:40:28 UTC) #29
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6a5e24b29b4438185ed04663794962274501c478
Cr-Commit-Position: refs/heads/master@{#35294}

Powered by Google App Engine
This is Rietveld 408576698