Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1851733002: [heap] Fix computation of flags offset in memorychunk (Closed)

Created:
4 years, 8 months ago by Michael Lippautz
Modified:
4 years, 8 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Fix computation of flags offset in memorychunk BUG=chromium:581412 LOG=N R=hpayer@chromium.org Committed: https://crrev.com/42aa01e0212d47cc6a38d42bbcf6abf82b957e9a Cr-Commit-Position: refs/heads/master@{#35189}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -172 lines) Patch
M src/frames.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/incremental-marking.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/heap/mark-compact.h View 1 7 chunks +97 lines, -58 lines 0 comments Download
M src/heap/mark-compact.cc View 1 22 chunks +154 lines, -91 lines 0 comments Download
M src/heap/mark-compact-inl.h View 1 1 chunk +0 lines, -11 lines 0 comments Download
M src/heap/spaces.cc View 1 4 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Hannes Payer (out of office)
lgtm
4 years, 8 months ago (2016-04-01 07:01:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851733002/1
4 years, 8 months ago (2016-04-01 07:02:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 07:27:44 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 07:28:37 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/42aa01e0212d47cc6a38d42bbcf6abf82b957e9a
Cr-Commit-Position: refs/heads/master@{#35189}

Powered by Google App Engine
This is Rietveld 408576698