Skip shadow hosts with negative tabindex in focus navigation

Skip shadow hosts with negative tabindex in focus navigation

This CL implements a new focus navigation behavior with negative index-ed shadow hosts; Shadow hosts with negative tabindex and their descendants are completely skipped.
See the spec here: https://w3c.github.io/webcomponents/spec/shadow/#sequential-focus-navigation

BUG=600621
Committed: https://crrev.com/891ceec45f09bcc6664ad1fcb0684e16f7a3d053
Cr-Commit-Position: refs/heads/master@{#385701}

[yuzuchan, 2016-04-05 06:58:38]

yuzus@chromium.org changed reviewers:
+ hayato@chromium.org, kochi@chromium.org

[yuzuchan, 2016-04-05 06:58:39]

PTAL

This is how I feel about this patch: http://i.imgur.com/DZYEzgE.gif

[hayato, 2016-04-05 08:53:06]

LGTM

https://codereview.chromium.org/1862563002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/shadow-dom/focus-with-negative-index.html
(right):

https://codereview.chromium.org/1862563002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/shadow-dom/focus-with-negative-index.html:38:
<input id="ignored-input-in-shadow-host2" tabindex=2 value="ignored">
As we chatted offline, could you add a layout test for:

1. Focus "ignored-input-in-shadow-host2
2. Then, press tab-key

to catch a regression in the future?

Any behavior is okay, as of now.

[kochi, 2016-04-05 09:37:13]

Looks this breaks existing layout tests.
Could you take a look?

[yuzuchan, 2016-04-05 09:50:50]

On 2016/04/05 at 09:37:13, kochi wrote:
> Looks this breaks existing layout tests.
> Could you take a look?

The changes I made to the existing layout tests are intentional:
V1 shadow tree whose host's tabindex is negative should now be completely
skipped.

[yuzuchan, 2016-04-05 09:52:00]

This is how I feel about this patch: http://i.imgur.com/BDDnrYg.gif

https://codereview.chromium.org/1862563002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/shadow-dom/focus-with-negative-index.html
(right):

https://codereview.chromium.org/1862563002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/shadow-dom/focus-with-negative-index.html:38:
<input id="ignored-input-in-shadow-host2" tabindex=2 value="ignored">
On 2016/04/05 at 08:53:06, hayato wrote:
> As we chatted offline, could you add a layout test for:
> 
> 1. Focus "ignored-input-in-shadow-host2
> 2. Then, press tab-key
> 
> to catch a regression in the future?
> 
> Any behavior is okay, as of now.

Done.

[hayato, 2016-04-06 05:58:20]

LGTM again. Thank you for updating!

[kochi, 2016-04-06 06:18:35]

On 2016/04/05 09:50:50, yuzuchan wrote:
> On 2016/04/05 at 09:37:13, kochi wrote:
> > Looks this breaks existing layout tests.
> > Could you take a look?
> 
> The changes I made to the existing layout tests are intentional:
> V1 shadow tree whose host's tabindex is negative should now be completely
> skipped.

I was referring to the old patchset (1).
now lgtm

[yuzuchan, 2016-04-07 08:29:19]

The CQ bit was checked by yuzus@chromium.org

[commit-bot: I haz the power, 2016-04-07 08:29:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1862563002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1862563002/60001

[commit-bot: I haz the power, 2016-04-07 09:46:54]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-07 09:48:13]

Description was changed from

==========
Skip shadow hosts with negative tabindex in focus navigation

This CL implements a new focus navigation behavior with negative index-ed shadow
hosts; Shadow hosts with negative tabindex and their descendants are completely
skipped.
See the spec here:
https://w3c.github.io/webcomponents/spec/shadow/#sequential-focus-navigation

BUG=600621
==========

to

==========
Skip shadow hosts with negative tabindex in focus navigation

This CL implements a new focus navigation behavior with negative index-ed shadow
hosts; Shadow hosts with negative tabindex and their descendants are completely
skipped.
See the spec here:
https://w3c.github.io/webcomponents/spec/shadow/#sequential-focus-navigation

BUG=600621

Committed: https://crrev.com/891ceec45f09bcc6664ad1fcb0684e16f7a3d053
Cr-Commit-Position: refs/heads/master@{#385701}
==========

[commit-bot: I haz the power, 2016-04-07 09:48:14]

Patchset 4 (id:??) landed as
https://crrev.com/891ceec45f09bcc6664ad1fcb0684e16f7a3d053
Cr-Commit-Position: refs/heads/master@{#385701}