third_party/WebKit/Source/core/page/FocusController.cpp - Issue 1862563002: Skip shadow hosts with negative tabindex in focus navigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/FocusController.cpp

Issue 1862563002: Skip shadow hosts with negative tabindex in focus navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Refactor Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/page/FocusController.cpp

diff --git a/third_party/WebKit/Source/core/page/FocusController.cpp b/third_party/WebKit/Source/core/page/FocusController.cpp

index e7db0e88b3fb5fee07ff302a4ae00a7ad489d90b..24183898766552d15dcd2820c11909263f801ad6 100644

--- a/third_party/WebKit/Source/core/page/FocusController.cpp

+++ b/third_party/WebKit/Source/core/page/FocusController.cpp

@@ -373,7 +373,7 @@ inline bool isNonFocusableShadowHost(const Element& element)

inline bool isNonKeyboardFocusableShadowHost(const Element& element)

{

- return isShadowHostWithoutCustomFocusLogic(element) && !element.isKeyboardFocusable();

+ return isShadowHostWithoutCustomFocusLogic(element) && !(element.shadowRootIfV1() ? element.isFocusable() : element.isKeyboardFocusable());

}

inline bool isKeyboardFocusableShadowHost(const Element& element)

« no previous file with comments | « third_party/WebKit/LayoutTests/shadow-dom/focus-with-negative-index.html ('k') | no next file » | no next file with comments »