Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 1862513004: Revert of Improve DEFINE_STATIC_LOCAL()'s handling of Blink GCed objects. (Closed)

Created:
4 years, 8 months ago by Jeffrey Yasskin
Modified:
4 years, 8 months ago
Reviewers:
oilpan-reviews, haraken, sof
CC:
chromium-reviews, blink-reviews-html_chromium.org, blink-reviews-style_chromium.org, blink-reviews-css, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Improve DEFINE_STATIC_LOCAL()'s handling of Blink GCed objects. (patchset #8 id:140001 of https://codereview.chromium.org/1850413002/ ) Reason for revert: Caused leaks in https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%282%29/builds/54690/steps/memory_test%3A%20extensions_unittests/logs/stdio: Leak_DefinitelyLost 16 bytes in 1 blocks are definitely lost in loss record 346 of 2,713 malloc (m_replacemalloc/vg_replace_malloc.c:1138) WTF::Partitions::fastMalloc(unsigned long, char const*) (third_party/WebKit/Source/wtf/PartitionAlloc.h:736) blink::PersistentBase<blink::HeapHashSet<blink::WeakMember<blink::FontCacheClient>, WTF::WeakMemberHash<blink::FontCacheClient>, WTF::HashTraits<blink::WeakMember<blink::FontCacheClient> > >, (blink::WeaknessPersistentConfiguration)0, (blink::CrossThreadnessPersistentConfiguration)0>::operator new(unsigned long) (/mnt/data/b/build/slave/chromium-rel-linux-valgrind-tests-2/build/src/out/Release/extensions_unittests) blink::fontCacheClients() (third_party/WebKit/Source/platform/fonts/FontCache.cpp:300) blink::FontCache::addClient(blink::FontCacheClient*) (third_party/WebKit/Source/platform/fonts/FontCache.cpp:308) blink::CSSFontSelector::CSSFontSelector(blink::Document*) (third_party/WebKit/Source/core/css/CSSFontSelector.cpp:56) blink::CSSFontSelector::create(blink::Document*) (/mnt/data/b/build/slave/chromium-rel-linux-valgrind-tests-2/build/src/out/Release/extensions_unittests) Leak_DefinitelyLost 16 bytes in 1 blocks are definitely lost in loss record 352 of 2,713 malloc (m_replacemalloc/vg_replace_malloc.c:1138) WTF::Partitions::fastMalloc(unsigned long, char const*) (third_party/WebKit/Source/wtf/PartitionAlloc.h:736) blink::PersistentBase<blink::HeapHashSet<blink::Member<blink::Widget>, WTF::MemberHash<blink::Widget>, WTF::HashTraits<blink::Member<blink::Widget> > >, (blink::WeaknessPersistentConfiguration)0, (blink::CrossThreadnessPersistentConfiguration)0>::operator new(unsigned long) (/mnt/data/b/build/slave/chromium-rel-linux-valgrind-tests-2/build/src/out/Release/extensions_unittests) blink::widgetsPendingTemporaryRemovalFromParent() (third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp:53) blink::HTMLFrameOwnerElement::UpdateSuspendScope::performDeferredWidgetTreeOperations() (third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp:91) blink::HTMLFrameOwnerElement::UpdateSuspendScope::~UpdateSuspendScope() (third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp:103) Leak_DefinitelyLost 16 bytes in 1 blocks are definitely lost in loss record 347 of 2,713 malloc (m_replacemalloc/vg_replace_malloc.c:1138) WTF::Partitions::fastMalloc(unsigned long, char const*) (third_party/WebKit/Source/wtf/PartitionAlloc.h:736) blink::PersistentBase<blink::HeapHashSet<blink::WeakMember<blink::Document>, WTF::WeakMemberHash<blink::Document>, WTF::HashTraits<blink::WeakMember<blink::Document> > >, (blink::WeaknessPersistentConfiguration)0, (blink::CrossThreadnessPersistentConfiguration)0>::operator new(unsigned long) (/mnt/data/b/build/slave/chromium-rel-linux-valgrind-tests-2/build/src/out/Release/extensions_unittests) blink::Document::liveDocumentSet() (third_party/WebKit/Source/core/dom/Document.cpp:366) blink::Document::Document(blink::DocumentInit const&, unsigned char) (third_party/WebKit/Source/core/dom/Document.cpp:509) blink::HTMLDocument::HTMLDocument(blink::DocumentInit const&, unsigned char) (third_party/WebKit/Source/core/html/HTMLDocument.cpp:71) Original issue's description: > Improve DEFINE_STATIC_LOCAL()'s handling of Blink GCed objects. > > Extend DEFINE_STATIC_LOCAL() to automatically wrap up heap objects > being exposed as static singletons -- the wrapping happening by > way of a Persistent<>. > > With that in place, simplify various uses of DEFINE_STATIC_LOCAL() > along with phasing out the use of DEFINE_STATIC_REF_WILL_BE_PERSISTENT() > entirely. > > R=haraken > BUG=585328 > > Committed: https://crrev.com/18dc8ecff5ba68d28fc536f723ae3c57eafa1b4e > Cr-Commit-Position: refs/heads/master@{#384887} > > Committed: https://crrev.com/6b2e026b1c11833d558c8fd5c9d427f04ec3757b > Cr-Commit-Position: refs/heads/master@{#384904} TBR=oilpan-reviews@chromium.org,haraken@chromium.org,sigbjornf@opera.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=585328

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+287 lines, -331 lines) Patch
M third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPathValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSPathValue.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValuePool.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySerializer.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ChildListMutationScope.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ContextFeatures.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ContextFeatures.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentOrderedMap.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MutationObserver.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/PresentationAttributeStyle.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TreeScope.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/WeakIdentifierMap.h View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementMicrotaskDispatcher.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementObserver.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementProcessingStack.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementScheduler.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStyle.cpp View 5 chunks +13 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarker.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventDispatcher.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/FetchContext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.h View 2 chunks +14 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 5 chunks +58 lines, -71 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Frame.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSourceElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLStyleElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTableElement.cpp View 2 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/input/InputDeviceCapabilities.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/ImageLoader.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 2 chunks +13 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGStyleElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp View 2 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XPathValue.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/battery/BatteryDispatcher.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/device_light/DeviceLightDispatcher.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DeviceMotionDispatcher.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DeviceOrientationDispatcher.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/GamepadDispatcher.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationDispatcher.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCache.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/StdLibExtras.h View 2 chunks +24 lines, -54 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jeffrey Yasskin
Created Revert of Improve DEFINE_STATIC_LOCAL()'s handling of Blink GCed objects.
4 years, 8 months ago (2016-04-05 20:33:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862513004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862513004/1
4 years, 8 months ago (2016-04-05 20:33:41 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 20:49:46 UTC) #4
Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

Powered by Google App Engine
This is Rietveld 408576698