Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1862513003: Remove NPAPI from browser and utility (Closed)

Created:
4 years, 8 months ago by piman
Modified:
4 years, 8 months ago
CC:
asanka, asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, danakj+watch_chromium.org, darin-cc_chromium.org, extensions-reviews_chromium.org, jam, jbauman+watch_chromium.org, jochen+watch_chromium.org, kalyank, loading-reviews_chromium.org, markusheintz_, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, msramek+watch_chromium.org, nasko+codewatch_chromium.org, nona+watch_chromium.org, Peter Beverloo, piman+watch_chromium.org, raymes+watch_chromium.org, rickyz+watch_chromium.org, shuchen+watch_chromium.org, sievers+watch_chromium.org, James Su, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove NPAPI from browser and utility This pulls a lot of hairballs but that's pretty much everything left. BUG=493212, 123851, 234591, 238460 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/e8c57eac849fb54583b267101793296c5ca0d940 Cr-Commit-Position: refs/heads/master@{#385358}

Patch Set 1 : rebase #

Total comments: 6

Patch Set 2 : fix build #

Total comments: 6

Patch Set 3 : fixes #

Patch Set 4 : more fixes #

Total comments: 16

Patch Set 5 : fixes #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -4894 lines) Patch
M base/mac/mac_util.h View 1 chunk +0 lines, -6 lines 0 comments Download
M base/mac/mac_util.mm View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/app/chrome_crash_reporter_client.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/chrome_main_delegate.cc View 2 chunks +1 line, -7 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 2 3 4 5 3 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/app_controller_mac.mm View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 2 3 4 5 6 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/chrome_plugin_browsertest.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/download/download_target_determiner_unittest.cc View 2 chunks +0 lines, -67 lines 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_apitest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/crx_installer_browsertest.cc View 1 2 3 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/extensions/plugin_apitest.cc View 1 chunk +0 lines, -200 lines 0 comments Download
M chrome/browser/extensions/plugin_manager.cc View 3 chunks +0 lines, -35 lines 0 comments Download
M chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/metrics/metrics_memory_details.cc View 4 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/metrics/plugin_metrics_provider.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/metrics/plugin_metrics_provider.cc View 3 chunks +4 lines, -11 lines 0 comments Download
M chrome/browser/metrics/plugin_metrics_provider_unittest.cc View 1 2 7 chunks +19 lines, -24 lines 0 comments Download
M chrome/browser/performance_monitor/process_metrics_history.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/plugins/chrome_plugin_service_filter.h View 4 chunks +0 lines, -41 lines 0 comments Download
M chrome/browser/plugins/chrome_plugin_service_filter.cc View 4 chunks +0 lines, -243 lines 0 comments Download
M chrome/browser/plugins/plugin_finder.h View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/plugins/plugin_finder.cc View 2 chunks +0 lines, -25 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.cc View 1 5 chunks +1 line, -61 lines 0 comments Download
M chrome/browser/plugins/plugin_prefs_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/printing/print_preview_dialog_controller_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/print_preview_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/task_management/providers/child_process_task.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/task_management/providers/child_process_task_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/task_manager/child_process_resource_provider.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/task_profiler/task_profiler_data_serializer.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/plugins/plugins_handler.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/crash_keys.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/render_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 3 chunks +2 lines, -27 lines 0 comments Download
M chrome/renderer/content_settings_observer.h View 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/renderer/content_settings_observer.cc View 5 chunks +0 lines, -11 lines 0 comments Download
D chrome/test/data/extensions/uitest/plugins/README View 1 2 3 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/test/data/extensions/uitest/plugins/manifest.json View 1 2 3 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/test/data/extensions/uitest/plugins/plugin.dll View 1 2 3 Binary file 0 comments Download
D chrome/test/data/extensions/uitest/plugins/plugin.plugin/Contents/Info.plist View 1 2 3 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/test/data/extensions/uitest/plugins/plugin.plugin/Contents/MacOS/TestNetscapePlugIn View 1 2 3 Binary file 0 comments Download
D chrome/test/data/extensions/uitest/plugins/plugin32.so View 1 2 3 Binary file 0 comments Download
D chrome/test/data/extensions/uitest/plugins/plugin64.so View 1 2 3 Binary file 0 comments Download
D chrome/test/data/extensions/uitest/plugins/test.html View 1 2 3 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/test/data/extensions/uitest/plugins/test.js View 1 2 3 1 chunk +0 lines, -29 lines 0 comments Download
M components/content_settings/content/common/content_settings_messages.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/infobars/core/infobar_delegate.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/profiler/content/content_tracking_synchronizer_delegate.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/metrics/profiler/tracking_synchronizer_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/metrics/proto/profiler_event.proto View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/browser_child_process_host_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/child_process_security_policy_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/render_frame_message_filter.h View 3 chunks +0 lines, -13 lines 0 comments Download
M content/browser/frame_host/render_frame_message_filter.cc View 4 chunks +0 lines, -119 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.h View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.h View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 2 3 4 5 1 chunk +0 lines, -17 lines 0 comments Download
M content/browser/histogram_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/loader/resource_loader.cc View 1 2 3 4 5 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/loader/resource_request_info_impl.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M content/browser/plugin_data_remover_impl.cc View 11 chunks +18 lines, -67 lines 0 comments Download
D content/browser/plugin_loader_posix.h View 1 chunk +0 lines, -134 lines 0 comments Download
D content/browser/plugin_loader_posix.cc View 1 chunk +0 lines, -237 lines 0 comments Download
D content/browser/plugin_loader_posix_unittest.cc View 1 chunk +0 lines, -426 lines 0 comments Download
D content/browser/plugin_process_host.h View 1 chunk +0 lines, -211 lines 0 comments Download
D content/browser/plugin_process_host.cc View 1 chunk +0 lines, -407 lines 0 comments Download
D content/browser/plugin_process_host_mac.cc View 1 chunk +0 lines, -107 lines 0 comments Download
M content/browser/plugin_service_impl.h View 9 chunks +0 lines, -86 lines 0 comments Download
M content/browser/plugin_service_impl.cc View 14 chunks +11 lines, -424 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/utility_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M content/common/content_constants_internal.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/common/content_constants_internal.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/common/content_message_generator.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/content_switches_internal.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/common/content_switches_internal.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M content/common/frame_messages.h View 1 2 3 4 5 1 chunk +0 lines, -12 lines 0 comments Download
D content/common/plugin_constants_win.h View 1 chunk +0 lines, -30 lines 0 comments Download
D content/common/plugin_constants_win.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M content/common/plugin_list.h View 9 chunks +3 lines, -69 lines 0 comments Download
M content/common/plugin_list.cc View 9 chunks +22 lines, -138 lines 0 comments Download
D content/common/plugin_list_mac.mm View 1 chunk +0 lines, -310 lines 0 comments Download
D content/common/plugin_list_posix.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M content/common/plugin_list_unittest.cc View 6 chunks +2 lines, -6 lines 0 comments Download
D content/common/plugin_list_win.cc View 1 chunk +0 lines, -493 lines 0 comments Download
D content/common/plugin_process_messages.h View 1 chunk +0 lines, -81 lines 0 comments Download
M content/common/process_type.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/sandbox_init_mac.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/common/utility_messages.h View 1 2 3 4 2 chunks +0 lines, -32 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
D content/common/webplugin_geometry.h View 1 chunk +0 lines, -34 lines 0 comments Download
D content/common/webplugin_geometry.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M content/content_common.gypi View 4 chunks +0 lines, -12 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/browser_child_process_observer.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/browser/plugin_service.h View 5 chunks +0 lines, -29 lines 0 comments Download
M content/public/browser/plugin_service_filter.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/public/common/content_switches.h View 7 chunks +0 lines, -15 lines 0 comments Download
M content/public/common/content_switches.cc View 9 chunks +3 lines, -42 lines 0 comments Download
M content/public/common/process_type.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/webplugininfo.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/webplugininfo.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/app/blink_test_platform_support_mac.mm View 1 chunk +0 lines, -10 lines 0 comments Download
M content/shell/app/shell_crash_reporter_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/browser/shell_content_browser_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M content/test/fake_plugin_service.h View 2 chunks +0 lines, -10 lines 0 comments Download
M content/test/fake_plugin_service.cc View 4 chunks +0 lines, -27 lines 0 comments Download
M content/utility/utility_thread_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/utility/utility_thread_impl.cc View 2 chunks +0 lines, -25 lines 0 comments Download
M ipc/ipc_message_start.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views_content_client/views_content_client_main_parts_mac.mm View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 43 (16 generated)
piman
Sorry about the giant CL, but it pretty much only removes stuff (that was entangled ...
4 years, 8 months ago (2016-04-05 06:00:48 UTC) #5
dcheng
https://codereview.chromium.org/1862513003/diff/40001/chrome/browser/extensions/plugin_apitest.cc File chrome/browser/extensions/plugin_apitest.cc (left): https://codereview.chromium.org/1862513003/diff/40001/chrome/browser/extensions/plugin_apitest.cc#oldcode57 chrome/browser/extensions/plugin_apitest.cc:57: test_data_dir_.AppendASCII("uitest").AppendASCII("plugins"); Can we delete https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/data/extensions/uitest/plugins/ as well? https://codereview.chromium.org/1862513003/diff/40001/content/common/utility_messages.h File ...
4 years, 8 months ago (2016-04-05 06:12:15 UTC) #6
Peter Kasting
LGTM https://codereview.chromium.org/1862513003/diff/40001/components/infobars/core/infobar_delegate.h File components/infobars/core/infobar_delegate.h (left): https://codereview.chromium.org/1862513003/diff/40001/components/infobars/core/infobar_delegate.h#oldcode100 components/infobars/core/infobar_delegate.h:100: NPAPI_REMOVAL_INFOBAR_DELEGATE = 30, Nit: Rather than remove this ...
4 years, 8 months ago (2016-04-05 06:40:07 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862513003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862513003/80001
4 years, 8 months ago (2016-04-05 08:14:14 UTC) #9
piman
https://codereview.chromium.org/1862513003/diff/40001/chrome/browser/extensions/plugin_apitest.cc File chrome/browser/extensions/plugin_apitest.cc (left): https://codereview.chromium.org/1862513003/diff/40001/chrome/browser/extensions/plugin_apitest.cc#oldcode57 chrome/browser/extensions/plugin_apitest.cc:57: test_data_dir_.AppendASCII("uitest").AppendASCII("plugins"); On 2016/04/05 06:12:15, dcheng wrote: > Can we ...
4 years, 8 months ago (2016-04-05 08:15:30 UTC) #10
dcheng
ipc changes lgtm https://codereview.chromium.org/1862513003/diff/80001/content/common/utility_messages.h File content/common/utility_messages.h (right): https://codereview.chromium.org/1862513003/diff/80001/content/common/utility_messages.h#newcode7 content/common/utility_messages.h:7: #include "build/build_config.h" This one too, I ...
4 years, 8 months ago (2016-04-05 08:18:04 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-05 09:36:45 UTC) #13
Avi (use Gerrit)
You remove a lot of UMA. Are you cleaning up the histograms xml file too? ...
4 years, 8 months ago (2016-04-05 12:36:44 UTC) #14
Alexei Svitkine (slow)
https://codereview.chromium.org/1862513003/diff/80001/components/metrics/proto/profiler_event.proto File components/metrics/proto/profiler_event.proto (left): https://codereview.chromium.org/1862513003/diff/80001/components/metrics/proto/profiler_event.proto#oldcode108 components/metrics/proto/profiler_event.proto:108: PLUGIN = 3; Instead of removing this, please add ...
4 years, 8 months ago (2016-04-05 14:57:22 UTC) #15
piman
https://codereview.chromium.org/1862513003/diff/80001/components/metrics/proto/profiler_event.proto File components/metrics/proto/profiler_event.proto (left): https://codereview.chromium.org/1862513003/diff/80001/components/metrics/proto/profiler_event.proto#oldcode108 components/metrics/proto/profiler_event.proto:108: PLUGIN = 3; On 2016/04/05 14:57:22, Alexei Svitkine wrote: ...
4 years, 8 months ago (2016-04-05 15:12:09 UTC) #16
piman
https://codereview.chromium.org/1862513003/diff/80001/content/common/utility_messages.h File content/common/utility_messages.h (right): https://codereview.chromium.org/1862513003/diff/80001/content/common/utility_messages.h#newcode7 content/common/utility_messages.h:7: #include "build/build_config.h" On 2016/04/05 08:18:04, dcheng wrote: > This ...
4 years, 8 months ago (2016-04-05 15:16:38 UTC) #17
piman
On Tue, Apr 5, 2016 at 5:36 AM, <avi@chromium.org> wrote: > You remove a lot ...
4 years, 8 months ago (2016-04-05 15:19:21 UTC) #18
Mark Mentovai
LGTM in base/mac
4 years, 8 months ago (2016-04-05 15:21:23 UTC) #19
jam
lgtm https://codereview.chromium.org/1862513003/diff/80001/chrome/browser/plugins/chrome_plugin_service_filter.h File chrome/browser/plugins/chrome_plugin_service_filter.h (right): https://codereview.chromium.org/1862513003/diff/80001/chrome/browser/plugins/chrome_plugin_service_filter.h#newcode45 chrome/browser/plugins/chrome_plugin_service_filter.h:45: void OverridePluginForFrame(int render_process_id, this is called by two ...
4 years, 8 months ago (2016-04-05 15:54:36 UTC) #20
sky
https://codereview.chromium.org/1862513003/diff/80001/chrome/browser/plugins/plugin_info_message_filter.cc File chrome/browser/plugins/plugin_info_message_filter.cc (left): https://codereview.chromium.org/1862513003/diff/80001/chrome/browser/plugins/plugin_info_message_filter.cc#oldcode389 chrome/browser/plugins/plugin_info_message_filter.cc:389: // Check if the plugin or its group is ...
4 years, 8 months ago (2016-04-05 16:45:29 UTC) #21
piman
https://codereview.chromium.org/1862513003/diff/80001/chrome/browser/plugins/plugin_info_message_filter.cc File chrome/browser/plugins/plugin_info_message_filter.cc (left): https://codereview.chromium.org/1862513003/diff/80001/chrome/browser/plugins/plugin_info_message_filter.cc#oldcode389 chrome/browser/plugins/plugin_info_message_filter.cc:389: // Check if the plugin or its group is ...
4 years, 8 months ago (2016-04-05 17:10:01 UTC) #22
Avi (use Gerrit)
LGTM with fixes Don't worry about doing the histogram XML in this patch, as long ...
4 years, 8 months ago (2016-04-05 17:35:35 UTC) #23
sky
LGTM https://codereview.chromium.org/1862513003/diff/80001/chrome/browser/plugins/plugin_info_message_filter.cc File chrome/browser/plugins/plugin_info_message_filter.cc (left): https://codereview.chromium.org/1862513003/diff/80001/chrome/browser/plugins/plugin_info_message_filter.cc#oldcode389 chrome/browser/plugins/plugin_info_message_filter.cc:389: // Check if the plugin or its group ...
4 years, 8 months ago (2016-04-05 19:11:15 UTC) #24
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862513003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862513003/120001
4 years, 8 months ago (2016-04-05 19:56:12 UTC) #26
piman
https://codereview.chromium.org/1862513003/diff/80001/chrome/browser/plugins/chrome_plugin_service_filter.h File chrome/browser/plugins/chrome_plugin_service_filter.h (right): https://codereview.chromium.org/1862513003/diff/80001/chrome/browser/plugins/chrome_plugin_service_filter.h#newcode45 chrome/browser/plugins/chrome_plugin_service_filter.h:45: void OverridePluginForFrame(int render_process_id, On 2016/04/05 15:54:35, jam wrote: > ...
4 years, 8 months ago (2016-04-05 19:59:29 UTC) #27
Alexei Svitkine (slow)
components/metrics lgtm % the server-side CL - thanks!
4 years, 8 months ago (2016-04-05 20:25:37 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862513003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862513003/120001
4 years, 8 months ago (2016-04-05 20:44:52 UTC) #32
commit-bot: I haz the power
Failed to apply patch for chrome/browser/extensions/extension_renderer_state.cc: While running git apply --index -3 -p1; error: chrome/browser/extensions/extension_renderer_state.cc: ...
4 years, 8 months ago (2016-04-05 21:26:10 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862513003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862513003/140001
4 years, 8 months ago (2016-04-05 23:26:36 UTC) #38
commit-bot: I haz the power
Committed patchset #7 (id:140001)
4 years, 8 months ago (2016-04-06 01:19:53 UTC) #40
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/e8c57eac849fb54583b267101793296c5ca0d940 Cr-Commit-Position: refs/heads/master@{#385358}
4 years, 8 months ago (2016-04-06 01:21:46 UTC) #42
Will Harris
4 years, 8 months ago (2016-04-06 01:26:49 UTC) #43
Message was sent while issue was closed.
🎉 \( ̄▽ ̄)/ 🎉

Powered by Google App Engine
This is Rietveld 408576698