Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: content/browser/frame_host/render_frame_message_filter.cc

Issue 1862513003: Remove NPAPI from browser and utility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_message_filter.cc
diff --git a/content/browser/frame_host/render_frame_message_filter.cc b/content/browser/frame_host/render_frame_message_filter.cc
index 6a9613f091339d8f418d1d129b25a242cbf7e4c2..c21a25e91749ece483c42adb7ce8e0e2ab370cde 100644
--- a/content/browser/frame_host/render_frame_message_filter.cc
+++ b/content/browser/frame_host/render_frame_message_filter.cc
@@ -142,80 +142,6 @@ class RenderFrameMessageFilter::OpenChannelToPpapiBrokerCallback
int routing_id_;
};
-class RenderFrameMessageFilter::OpenChannelToNpapiPluginCallback
- : public RenderMessageCompletionCallback,
- public PluginProcessHost::Client {
- public:
- OpenChannelToNpapiPluginCallback(RenderFrameMessageFilter* filter,
- ResourceContext* context,
- IPC::Message* reply_msg)
- : RenderMessageCompletionCallback(filter, reply_msg),
- context_(context),
- host_(nullptr),
- sent_plugin_channel_request_(false) {
- }
-
- int ID() override { return filter()->render_process_id_; }
-
- ResourceContext* GetResourceContext() override { return context_; }
-
- bool OffTheRecord() override {
- if (filter()->incognito_)
- return true;
- if (GetContentClient()->browser()->AllowSaveLocalState(context_))
- return false;
-
- // For now, only disallow storing data for Flash <http://crbug.com/97319>.
- for (const auto& type : info_.mime_types) {
- if (type.mime_type == kFlashPluginSwfMimeType)
- return true;
- }
- return false;
- }
-
- void SetPluginInfo(const WebPluginInfo& info) override { info_ = info; }
-
- void OnFoundPluginProcessHost(PluginProcessHost* host) override {
- DCHECK(host);
- host_ = host;
- }
-
- void OnSentPluginChannelRequest() override {
- sent_plugin_channel_request_ = true;
- }
-
- void OnChannelOpened(const IPC::ChannelHandle& handle) override {
- WriteReplyAndDeleteThis(handle);
- }
-
- void OnError() override { WriteReplyAndDeleteThis(IPC::ChannelHandle()); }
-
- PluginProcessHost* host() const {
- return host_;
- }
-
- bool sent_plugin_channel_request() const {
- return sent_plugin_channel_request_;
- }
-
- void Cancel() {
- delete this;
- }
-
- private:
- void WriteReplyAndDeleteThis(const IPC::ChannelHandle& handle) {
- FrameHostMsg_OpenChannelToPlugin::WriteReplyParams(reply_msg(),
- handle, info_);
- filter()->OnCompletedOpenChannelToNpapiPlugin(this);
- SendReplyAndDeleteThis();
- }
-
- ResourceContext* context_;
- WebPluginInfo info_;
- PluginProcessHost* host_;
- bool sent_plugin_channel_request_;
-};
-
class RenderFrameMessageFilter::OpenChannelToPpapiPluginCallback
: public RenderMessageCompletionCallback,
public PpapiPluginProcessHost::PluginClient {
@@ -272,27 +198,6 @@ RenderFrameMessageFilter::RenderFrameMessageFilter(
RenderFrameMessageFilter::~RenderFrameMessageFilter() {
// This function should be called on the IO thread.
DCHECK_CURRENTLY_ON(BrowserThread::IO);
-#if defined(ENABLE_PLUGINS)
- DCHECK(plugin_host_clients_.empty());
-#endif // ENABLE_PLUGINS
-}
-
-void RenderFrameMessageFilter::OnChannelClosing() {
-#if defined(ENABLE_PLUGINS)
- for (OpenChannelToNpapiPluginCallback* client : plugin_host_clients_) {
- if (client->host()) {
- if (client->sent_plugin_channel_request()) {
- client->host()->CancelSentRequest(client);
- } else {
- client->host()->CancelPendingRequest(client);
- }
- } else {
- plugin_service_->CancelOpenChannelToNpapiPlugin(client);
- }
- client->Cancel();
- }
- plugin_host_clients_.clear();
-#endif // ENABLE_PLUGINS
}
bool RenderFrameMessageFilter::OnMessageReceived(const IPC::Message& message) {
@@ -309,8 +214,6 @@ bool RenderFrameMessageFilter::OnMessageReceived(const IPC::Message& message) {
#if defined(ENABLE_PLUGINS)
IPC_MESSAGE_HANDLER_DELAY_REPLY(FrameHostMsg_GetPlugins, OnGetPlugins)
IPC_MESSAGE_HANDLER(FrameHostMsg_GetPluginInfo, OnGetPluginInfo)
- IPC_MESSAGE_HANDLER_DELAY_REPLY(FrameHostMsg_OpenChannelToPlugin,
- OnOpenChannelToPlugin)
IPC_MESSAGE_HANDLER_DELAY_REPLY(FrameHostMsg_OpenChannelToPepperPlugin,
OnOpenChannelToPepperPlugin)
IPC_MESSAGE_HANDLER(FrameHostMsg_DidCreateOutOfProcessPepperInstance,
@@ -558,28 +461,6 @@ void RenderFrameMessageFilter::OnGetPluginInfo(
nullptr, info, actual_mime_type);
}
-void RenderFrameMessageFilter::OnOpenChannelToPlugin(
- int render_frame_id,
- const GURL& url,
- const GURL& policy_url,
- const std::string& mime_type,
- IPC::Message* reply_msg) {
- OpenChannelToNpapiPluginCallback* client =
- new OpenChannelToNpapiPluginCallback(this, resource_context_, reply_msg);
- DCHECK(!ContainsKey(plugin_host_clients_, client));
- plugin_host_clients_.insert(client);
- plugin_service_->OpenChannelToNpapiPlugin(
- render_process_id_, render_frame_id,
- url, policy_url, mime_type, client);
-}
-
-void RenderFrameMessageFilter::OnCompletedOpenChannelToNpapiPlugin(
- OpenChannelToNpapiPluginCallback* client) {
- DCHECK_CURRENTLY_ON(BrowserThread::IO);
- DCHECK(ContainsKey(plugin_host_clients_, client));
- plugin_host_clients_.erase(client);
-}
-
void RenderFrameMessageFilter::OnOpenChannelToPepperPlugin(
const base::FilePath& path,
IPC::Message* reply_msg) {
« no previous file with comments | « content/browser/frame_host/render_frame_message_filter.h ('k') | content/browser/frame_host/render_widget_host_view_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698