Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1862493002: win: More attachment brokering for PlatformFileForTransit. (Closed)

Created:
4 years, 8 months ago by erikchen
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win: More attachment brokering for PlatformFileForTransit. Let the implementation of GetFileHandleForProcess() always duplicate the handle back into the current process. BUG=493414 Committed: https://crrev.com/56c6e5d5f098a14fdc619ea44cbe6e6558b37df2 Cr-Commit-Position: refs/heads/master@{#385232}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M ipc/ipc_platform_file.cc View 1 2 chunks +9 lines, -10 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862493002/20001
4 years, 8 months ago (2016-04-04 23:45:02 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/205310)
4 years, 8 months ago (2016-04-05 00:06:59 UTC) #4
erikchen
tsepez: Please review. Once this lands and sticks, I'll follow up with a large refactor ...
4 years, 8 months ago (2016-04-05 00:47:08 UTC) #6
Tom Sepez
lgtm
4 years, 8 months ago (2016-04-05 17:00:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862493002/20001
4 years, 8 months ago (2016-04-05 17:19:33 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-05 18:33:01 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 18:34:44 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/56c6e5d5f098a14fdc619ea44cbe6e6558b37df2
Cr-Commit-Position: refs/heads/master@{#385232}

Powered by Google App Engine
This is Rietveld 408576698