Add disable_brotli_filter and use_platform_icu_alternatives to cronet builder config.

Add disable_brotli_filter=1 and use_platform_icu_alternatives=1 to gyp defines for cronet_builder config.

BUG=601172
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299774

[mef, 2016-04-07 20:55:39]

Description was changed from

==========
Add disable_brotli_filter and use_platform_icu_alternatives to cronet builder
config.

BUG=
==========

to

==========
Add disable_brotli_filter and use_platform_icu_alternatives to cronet builder
config.

BUG=601172
==========

[mef, 2016-04-07 20:55:39]

mef@chromium.org changed reviewers:
+ jbudorick@chromium.org, kapishnikov@chromium.org

[mef, 2016-04-07 20:56:29]

Description was changed from

==========
Add disable_brotli_filter and use_platform_icu_alternatives to cronet builder
config.

BUG=601172
==========

to

==========
Add disable_brotli_filter=1 and use_platform_icu_alternatives=1 to gyp defines
for cronet_builder config.

BUG=601172
==========

[mef, 2016-04-07 20:56:39]

PTAL

[jbudorick, 2016-04-07 21:00:41]

lgtm

https://codereview.chromium.org/1862223004/diff/1/scripts/slave/recipes/crone...
File scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder.json
(right):

https://codereview.chromium.org/1862223004/diff/1/scripts/slave/recipes/crone...
scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder.json:161:
"GYP_CHROMIUM_NO_ACTION": "1",
I imagine you realize this, but just to make sure -- this change won't affect
any of the upstream bots.

[mef, 2016-04-07 21:07:44]

On 2016/04/07 20:56:39, mef wrote:
> PTAL

Do I need anything separate to update internal bots, or will it be handled by
recipe roller?

[mef, 2016-04-07 21:08:49]

On 2016/04/07 21:00:41, jbudorick wrote:
> lgtm
> 
>
https://codereview.chromium.org/1862223004/diff/1/scripts/slave/recipes/crone...
> File scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder.json
> (right):
> 
>
https://codereview.chromium.org/1862223004/diff/1/scripts/slave/recipes/crone...
> scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder.json:161:
> "GYP_CHROMIUM_NO_ACTION": "1",
> I imagine you realize this, but just to make sure -- this change won't affect
> any of the upstream bots.

Yes, those will be handled by mb_config changes in
https://codereview.chromium.org/1839803002

[mef, 2016-04-07 21:08:50]

On 2016/04/07 21:00:41, jbudorick wrote:
> lgtm
> 
>
https://codereview.chromium.org/1862223004/diff/1/scripts/slave/recipes/crone...
> File scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder.json
> (right):
> 
>
https://codereview.chromium.org/1862223004/diff/1/scripts/slave/recipes/crone...
> scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder.json:161:
> "GYP_CHROMIUM_NO_ACTION": "1",
> I imagine you realize this, but just to make sure -- this change won't affect
> any of the upstream bots.

Yes, those will be handled by mb_config changes in
https://codereview.chromium.org/1839803002

[mef, 2016-04-07 21:47:56]

The CQ bit was checked by mef@chromium.org

[commit-bot: I haz the power, 2016-04-07 21:48:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1862223004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1862223004/1

[jbudorick, 2016-04-07 21:53:12]

On 2016/04/07 21:07:44, mef wrote:
> On 2016/04/07 20:56:39, mef wrote:
> > PTAL
> 
> Do I need anything separate to update internal bots, or will it be handled by
> recipe roller?

the roller should send you a CL.

[commit-bot: I haz the power, 2016-04-07 21:55:29]

Description was changed from

==========
Add disable_brotli_filter=1 and use_platform_icu_alternatives=1 to gyp defines
for cronet_builder config.

BUG=601172
==========

to

==========
Add disable_brotli_filter=1 and use_platform_icu_alternatives=1 to gyp defines
for cronet_builder config.

BUG=601172

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299774
==========

[commit-bot: I haz the power, 2016-04-07 21:55:30]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299774